Updating AQM to CMAQv5.4 #101
Conversation
Feature/rrfs cmaq canopy
Fixed Makefile.in typo.
|
@bbakernoaa, https://github.com/noaa-oar-arl/AQM/tree/feature/cmaq54 is 3-month old. Where is the updated package? |
|
this is the latest that we have. We don't have anything newer at this juncture |
|
I heard that ARL has a fix to the soil type mix-up. Is that not for AQM? |
|
This is something that needs to be changed not just on the AQM side but also the FV3ATM side as well. We just finished some preliminary testing and such today. We will need to do PRs back to the UFS weather model for both changes (ie AQM and FV3ATM repositories) |
|
note that when we update to the GFS v17 physics we should also pass the fractional land use over and use this instead of the dominant value. Currently we are basically hard coding the fractional land use to be 1 for each dominate land use type in the grid cell and all other values are 0. |
|
I agree with Barry. We should handle this AQM/CMAQ54 update here, and
leave other updates including physics, bug fixes, etc in other separate PRs
as suitable.
…On Fri, Jan 3, 2025, 2:04 PM Barry Baker ***@***.***> wrote:
note that when we update to the GFS v17 physics we should also pass the
fractional land use over and use this instead of the dominant value.
Currently we are basically hard coding the fractional land use to be 1 for
each dominate land use type in the grid cell and all other values are 0.
—
Reply to this email directly, view it on GitHub
<#101 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNR5BF7MX6PJQOLMMDL2I3NMRAVCNFSM6AAAAABLA6CBLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRZGY4DOMRZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@BrianCurtis-NOAA How's it going moving this CMAQ54 PR forward, and is there a status update on a regression test? Do you need help from us to identify inputs, run directory, etc. to help get this setup and moved forward? |
|
@drnimbusrain We will need C96 support for AQM to get a proper regression test (C192 is acceptable if C96 complicates things) I don't need a workflow to get this merged, but a run directory with a working UFSWM will suffice so I can update the RT system to use it. As long as we have that, we can get this part merged in. Is this something that you might be able to put together? |
|
@BrianCurtis-NOAA could we not leverage: https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/tests/regional_atmaq We would just need to update the additional CMAQ related inputs and such for the updates no? |
Yes, that can be used as a template. |
|
I'm happy to put the work in taking a run directory and turning it into a proper RT if that will save you from too much work. The work on AQM-Workflow will eventually know how to generate such a run directory, but that will be a while. |
|
Thanks Brian. That link to regional_atmaq RT seems pretty old, yes? So,
to confirm you need a C96 run directory with AQM CMAQ54 updates that you
will use as a template for RT? We mainly have been running C793.
…On Fri, Jan 17, 2025, 4:01 PM Brian Curtis ***@***.***> wrote:
I'm happy to put the work in taking a run directory and turning it into a
proper RT if that will save you from too much work. The work on
AQM-Workflow will eventually know how to generate such a run directory, but
that will be a while.
—
Reply to this email directly, view it on GitHub
<#101 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNSO2MYVIQ6VIYAA3CL2LFVSPAVCNFSM6AAAAABLA6CBLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZGIYDCOBUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@drnimbusrain I think all we need to do is provide a run directory. The truth is most of the input files as far as emissions and such can be used for either 5.2 or 5.4. We just need to make sure we have an example to show the differences in the ancillary CMAQ files needed. Other than that the input files may need updated on the ATM side to accommodate the updates of the newer ATM hash. I can take a quick stab at it on Tuesday morning. At least to get something running. Point me to a run directory that you have for whatever resolution. Then @BrianCurtis-NOAA you could then integrate the updated files that RT needs into run RT workflow. |
|
Great news, thanks Barry. I'll send a run directory we have soon.
…On Fri, Jan 17, 2025, 9:43 PM Barry Baker ***@***.***> wrote:
@drnimbusrain <https://github.com/drnimbusrain> I think all we need to do
is provide a run directory. The truth is most of the input files as far as
emissions and such can be used for either 5.2 or 5.4. We just need to make
sure we have an example to show the differences in the ancillary CMAQ files
needed. Other than that the input files may need updated on the ATM side to
accommodate the updates of the newer ATM hash.
I can take a quick stab at it on Tuesday morning. At least to get
something running. Point me to a run directory that you have for whatever
resolution. Then @BrianCurtis-NOAA <https://github.com/BrianCurtis-NOAA>
you could then integrate the updated files that RT needs into run RT
workflow.
—
Reply to this email directly, view it on GitHub
<#101 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNSMACKRC4MCPTKEC532LG5TJAVCNFSM6AAAAABLA6CBLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZGQ4DGNZVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@BrianCurtis-NOAA @drnimbusrain please take a look here: I was able to get the RT for the regional_atmaq_debug going on hera with the updated feature/cmaq54 branch of the AQM. Note that this was off the latest develop branch of the UFSWM Files Changed |
|
are you using CCPP_SUITES=FV3_GFS_v16 ? |
|
the RT was using I'll try to quickly update it to |
|
@BrianCurtis-NOAA I updated it to use the |
|
@BrianCurtis-NOAA , what is the status of the PR merging ? |
|
@JianpingHuang-NOAA It will be a little bit. I'll get to looking at Barry's run dir soon. |
|
@BrianCurtis-NOAA Hi Brian, any update on this? |
|
@BrianCurtis-NOAA Hi Brian, we need to get this PR merged as soon as possible. Thanks ! |
|
@bbakernoaa I don't see the run directory you have listed above any more. Did you move it or have it somewhere else? |
typo, nevermind |
|
There have been some issues running the model with a debug build, with the most recent issue: Here is a diff of the changes that have been made so far diff --git a/src/model/src/centralized_io_module.F b/src/model/src/centralized_io_module.F
index c0605e6..e8d5b3a 100644
--- a/src/model/src/centralized_io_module.F
+++ b/src/model/src/centralized_io_module.F
@@ -1670,7 +1670,7 @@
if (NLDNSTRIKE) then
CALL NEXTIME ( loc_jdate(f_ltng), loc_jtime(f_ltng), file_tstep(f_ltng) )
end if
- CALL NEXTIME ( loc_jdate(f_bcon), loc_jtime(f_bcon), file_tstep(f_bcon) )
+! CALL NEXTIME ( loc_jdate(f_bcon), loc_jtime(f_bcon), file_tstep(f_bcon) )
#endif
do i = 1, N_FILE_GR
diff --git a/src/shr/aqm_methods.F90 b/src/shr/aqm_methods.F90
index 0098d07..5754a61 100644
--- a/src/shr/aqm_methods.F90
+++ b/src/shr/aqm_methods.F90
@@ -682,18 +682,20 @@ logical function interpx( fname, vname, pname, &
if (aqm_rc_check(localrc, msg="Failure to retrieve grid coordinates", &
file=__FILE__, line=__LINE__)) return
- if (vname(1:7) == 'LUFRAC_') then
- lu_index = 0
- read(vname(8:9), *, iostat=localrc) lu_index
- if (aqm_rc_test(localrc /= 0, msg="Failure to identify LU_INDEX", &
- file=__FILE__, line=__LINE__)) return
- k = 0
- do r = row0, row1
- do c = col0, col1
- k = k + 1
- if (int(stateIn % stype(c,r)) == lu_index) buffer(k) = 1.0
+ if (len(vname) > 7 ) then
+ if (vname(1:7) == 'LUFRAC_') then
+ lu_index = 0
+ read(vname(8:9), *, iostat=localrc) lu_index
+ if (aqm_rc_test(localrc /= 0, msg="Failure to identify LU_INDEX", &
+ file=__FILE__, line=__LINE__)) return
+ k = 0
+ do r = row0, row1
+ do c = col0, col1
+ k = k + 1
+ if (int(stateIn % stype(c,r)) == lu_index) buffer(k) = 1.0
+ end do
end do
- end do
+ end if
else
select case (trim(vname))
case ('HT')
@@ -1147,18 +1149,20 @@ LOGICAL FUNCTION XTRACT3 ( FNAME, VNAME, &
! end do
! end if
- if (vname(1:7) == 'LUFRAC_') then
- lu_index = 0
- read(vname(8:9), *, iostat=localrc) lu_index
- if (aqm_rc_test(localrc /= 0, msg="Failure to identify LU_INDEX", &
- file=__FILE__, line=__LINE__)) return
- k = 0
- do r = row0, row1
- do c = col0, col1
- k = k + 1
- if (int(stateIn % stype(c,r)) == lu_index) buffer(k) = 1.0
+ if (len(vname) > 7) then
+ if (vname(1:7) == 'LUFRAC_') then
+ lu_index = 0
+ read(vname(8:9), *, iostat=localrc) lu_index
+ if (aqm_rc_test(localrc /= 0, msg="Failure to identify LU_INDEX", &
+ file=__FILE__, line=__LINE__)) return
+ k = 0
+ do r = row0, row1
+ do c = col0, col1
+ k = k + 1
+ if (int(stateIn % stype(c,r)) == lu_index) buffer(k) = 1.0
+ end do
end do
- end do
+ end if
else
select case (trim(vname))
case ('HT') |
The array of soil type is supposed to > 0, though something could be wrong. To diagnose the issue, one method is adding some checking in case ("SLTYP") If the stype does show < 1, additional diagnose can be conducted in https://github.com/noaa-oar-arl/AQM/blob/feature/cmaq54/src/aqm_comp_mod.F90#L601 case ("soil_type") |
|
Latest error: |
In the file "CMAQ_Control_DESID.nml", try commenting out the namelist "Desid_SizeDist" !&Desid_SizeDist |
PR Checklist
This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:
[X ] This PR has been tested with the ufs-srweather-app workflow [aqm_dev] and [develop] branch.
[X ] New or updated input data is required by this PR.
To test this PR with CMAQv5.4 in AQMv7, you will need the following:
Updated aqm.rc template file that has updated mechanism (CB6r5AE7) and some other updates.
Updated diag_table_aqm.FV3_GFS_v6 and field_table_aqm.FV3_GFS_v16 to accommodate CMAQv5.4 changes.
[ X] Baselines are expected to change.
Description
This PR provides all necessary updates to AQM develop branch for ARL's work to update CMAQv5.4 submodule (from current CMAQv5.2.1) and all necessary AQM infrastructure to accommodate the CMAQv5.4 changes compared. Since our CMAQv5.4 changes were built upon our fork of the EMC develop branch, then it also contains some initial developments of our in-canopy photolysis infrastructure and code developments. The canopy option is turned off by default, and at this time, we recommend that the canopy option remains turned OFF (in aqm.rc) until further refined developments of the canopy codes in AQM (and later in UFS-SRW-App, UWM, FV3/CCPP, etc. via separate corresponding PRs to their authoritative repos to enable full functionality).
Issue(s) addressed
#100
Dependencies
Updates to UFS-SRW-App at non-default branches (e.g., production/AQM.v7) are needed to accommodate the CMAQv5.4 updates in AQM (see new or updated data section above). The question remains as to where and how to make these PRs. Our changes for CMAQv5.4 were built upon the previous [aqm_dev] branch of UFS-SRW-App, and do not correspond to the production/AQM.v7 branch. Please advise and we can update and make the correct PR to the correct UFS-SRW-App branch to accommodate testing the CMAQv5.4 updates to AQM.
@lwcugb @bbakernoaa @ytangnoaa