initialize cpl_scalar field when created #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
NickSzapiro-NOAA
approved these changes
Jul 17, 2024
dpsarmie
approved these changes
Jul 17, 2024
|
@DeniseWorthen testing is complete on your UFS-WM PR 2370. Feel free to merge this CICE sub-component PR. |
NickSzapiro-NOAA
pushed a commit
to NickSzapiro-NOAA/CICE
that referenced
this pull request
Aug 9, 2024
18 tasks
NickSzapiro-NOAA
added a commit
to NickSzapiro-NOAA/CICE
that referenced
this pull request
Aug 21, 2024
…e cpl_scalar field when created for UFS (CICE-Consortium#969) These are two commits cherry-picked from as in UFS and needed to close NOAA-EMC#84. This PR adds the ability for CICE to write restart files at the end of the run (independent of other settings) and controlled via the CMEPS configuration option write_restart_at_endofrun. Setting this configuration option to True creates a restart file in the same way for CMEPS, MOM6, and CICE. This PR also initializes the scalar field value for the index for NTile (implemented for FV3) not used or set in CICE. In certain cases, the scalar field value for this index has been found to be non-zero (NaN in debug compiles). This is the cause of the failure reported in ufs-community/ufs-weather-model#2338. * Add end of run functionality to CICE (NOAA-EMC#77) * initialize cpl_scalar field when created (NOAA-EMC#83) --------- Co-authored-by: Daniel Sarmiento <42810219+dpsarmie@users.noreply.github.com> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
NickSzapiro-NOAA
added a commit
that referenced
this pull request
Sep 25, 2024
…e cpl_scalar field when created for UFS (CICE-Consortium#969) These are two commits cherry-picked from as in UFS and needed to close #84. This PR adds the ability for CICE to write restart files at the end of the run (independent of other settings) and controlled via the CMEPS configuration option write_restart_at_endofrun. Setting this configuration option to True creates a restart file in the same way for CMEPS, MOM6, and CICE. This PR also initializes the scalar field value for the index for NTile (implemented for FV3) not used or set in CICE. In certain cases, the scalar field value for this index has been found to be non-zero (NaN in debug compiles). This is the cause of the failure reported in ufs-community/ufs-weather-model#2338. * Add end of run functionality to CICE (#77) * initialize cpl_scalar field when created (#83) --------- Co-authored-by: Daniel Sarmiento <42810219+dpsarmie@users.noreply.github.com> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ufs-community/ufs-weather-model#2369.
See related UFS #2369 for details.