Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/punyswrad #19

Merged
merged 21 commits into from
May 21, 2020
Merged

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented May 5, 2020

  1. Issue changes required for restart reproducibility in s2s #15
  • Adds coszen to restart file reading/writing (note: existing CICE5 ICs contain coszen but it is not being read).

  • Adds ice_aggregate call at initialization

  • Adds ability to read halo points in ice restart file for cases when they don't currently exist. If restart_ext is set .true. but the ice is from a non-CICE source (ie, cfsr, cpcice), CICE will not read the extra points; however they will be written to the restart file.

  • Replaces ice_shortwave routine with the equivalent routine from CESM_CICE5. The consistent difference is the conditional for determining when the sun is below the horizon. It is now set by calculating the net SW down > puny instead of cozen>puny.

  • Replaces constants in the cice_cap with specified R*8 equivalents.

  1. Issue timestamping of field dumps #14
  • When field dumps are enabled, all fields at a given import or export time will be written to a single file which has a filename timestamped with the applicable time. This replaces the existing field dumping, which writes all time values of a single field into a separate file (one for each field imported or exported).

Figures are shown below for ice concentration and surface temperature change from the IC after 5 days for ufs-s2s-model using the current develop branch of CICE5 compared to the feature/punyswrad branch. The evolution of these fields from the IC in the feature/punyswrad branch is nearly identical to the evolution in the develop branch.

aice_h_2012010100
aice_h_2012040100
aice_h_2012070100
aice_h_2012100100
Tsfc_h_2012010100
Tsfc_h_2012040100
Tsfc_h_2012070100
Tsfc_h_2012100100

Copy link
Collaborator

@binli2337 binli2337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good.

@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented May 19, 2020

I would like to push another change to this branch for CMEPS integration.

In CMEPS (as part of the CICE6 build) we want to remove the mediator calculation of air density and air potential temperature and have those fields calculated in the CICE cap. For CICE5 we have always calculated air potential temperature in the Cap, but calculated air density in the mediator.

The change will be to calculate air density in the Cap with the same formula and fields as used in the mediator.

Unfortunately, the air density calculation in the NEMS mediator is hard-coded. It is not conditional on the field being actually connected. To avoid having to make a change in the NEMS mediator also, I would propose that that air density still be advertised and connected but that the air density field be re-calculated in the CICE5 cap for both NEMS and CMEPS.

Proposed change:
DeniseWorthen/CICE5@feature/punyswrad...DeniseWorthen:feature/calc_rhoa

@DeniseWorthen DeniseWorthen merged commit 990d961 into NOAA-EMC:develop May 21, 2020
DeniseWorthen added a commit to DeniseWorthen/CICE5 that referenced this pull request May 24, 2020
@DeniseWorthen DeniseWorthen deleted the feature/punyswrad branch June 5, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changes required for restart reproducibility in s2s timestamping of field dumps
4 participants