Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a unique path name for each find_library #18

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Use a unique path name for each find_library #18

merged 1 commit into from
Feb 20, 2020

Conversation

kgerheiser
Copy link
Contributor

The paths are saved in the cache and are not overwritten by subsequent
calls to find_library using the same lib_path name

The paths are saved in the cache and are not overwritten by subsequent
calls to find_library using the same `lib_path` name
@mark-a-potts mark-a-potts merged commit 3c7e07f into NOAA-EMC:release/public-v1 Feb 20, 2020
@climbfuji
Copy link
Collaborator

Thanks for doing this. Sorry that I am late to the party, had a visitor arriving from Germany today. These changes don't affect the umbrella build, but nonetheless we should update the cmake submodule pointers in the various submodules of NCEPLIBS that use CMakeModules, in NCEPLIBS itself and in NCEPLIBS-external before we create the next tag. This way Dusan can test/use this in simple-ufs. Should I do that tomorrow (I've got copy & paste templates for updating cmake submodule pointers by now)?

@DusanJovic-NOAA
Copy link
Contributor

@climbfuji Yes, please. Update all NCEPLIBS public branches to point to this commit. And UFS_UTILS and EMC_post.

@climbfuji
Copy link
Collaborator

Done, also did the NCEPLIBS umbrella repo. Will do NCEPLIBS-external later (together with an update of the documentation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants