Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling in FindESMF.cmake #57

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Improve error handling in FindESMF.cmake #57

merged 2 commits into from
Sep 23, 2021

Conversation

DusanJovic-NOAA
Copy link
Contributor

@DusanJovic-NOAA DusanJovic-NOAA commented Sep 16, 2021 •
edited
Loading

  • Try to find ESMFMKFILE if it's not explicitly specified, in ESMF_ROOT or CMAKE_PREFIX_PATH
  • Do not set ESMF_FOUND explicitly, it will be set by find_package_handle_standard_args
  • Imported library is created only if ESMF is found
  • Use ether STATIC or SHARED as a library type instead of UNKNOWN

kgerheiser
kgerheiser suggested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@kgerheiser kgerheiser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except the version handling

Modules/FindESMF.cmake Show resolved Hide resolved
Modules/FindESMF.cmake Outdated Show resolved Hide resolved
kgerheiser
kgerheiser approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@kgerheiser kgerheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

climbfuji
climbfuji approved these changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on macOS with gcc+gfortran in the ufs-weather-model, and it worked.

@kgerheiser kgerheiser merged commit cedeb2c into NOAA-EMC:develop Sep 23, 2021
@climbfuji climbfuji mentioned this pull request Sep 23, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgerheiser kgerheiser kgerheiser approved these changes

@climbfuji climbfuji climbfuji approved these changes

@aerorahul aerorahul Awaiting requested review from aerorahul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DusanJovic-NOAA @kgerheiser @climbfuji