Feature/firewx #33
Feature/firewx #33
Conversation
This reverts commit 1799873. Correcting the mistake that accidentally erased the original merge.
|
You may work on the PR now. I changed my scripts from ksh to bash, and when I did so I noticed some errors in the number processing. I made some modifications and now it's working normally now. Thanks! Perry |
|
Thanks, Perry. As a reminder: python, perl, bash, *and korn shell* are
allowed in operations. Regular sh is not allowed in operations.
https://docs.google.com/presentation/d/15v-7rEM2CkJlEzwX4sE_qJd8DFJCgI726pzghIM_AwE/edit?pli=1#slide=id.ge5cc65791d_0_163
…___________________________________
*Alicia M. Bentley, Ph.D.*
Physical Scientist | Model Evaluation Group
<https://www.emc.ncep.noaa.gov/users/meg/home/>
Global Model Verification Team Lead
NOAA/NWS/NCEP/EMC (VPPPG Branch)
Work Phone: (301) 683-3783
On Fri, Nov 11, 2022 at 8:55 AM PerryShafran-NOAA ***@***.***> wrote:
You may work on the PR now. I changed my scripts from ksh to bash, and
when I did so I noticed some errors in the number processing. I made some
modifications and now it's working normally now.
Thanks!
Perry
—
Reply to this email directly, view it on GitHub
<#33 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APUWOBAP223EFMJ4BVZ7JVDWHZF4DANCNFSM6AAAAAAR47VKYI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I have checked out feature branch feature/firewx. I will commence the next steps soon. |
|
Hold once again, as I'm figuring out that StatAnalysis can only gather one data type at a time, which is why PBL stat lines were missing from the gathered output. I should have an update later on today. |
|
Changes made, ready for testing! |
|
Can this dir be removed? It should not be in the repository. It is full of binary files. |
|
Yes, it can be removed. |
|
I was able to test this PR running from my user environment. I generated stat files in both COMOUTsmall and COMOUTfinal. Perry has been informed and my output is under his review to make sure it agrees with his output. |
|
The final output file is now identical with Shelley's test. Perry |
jobs/cam/stats/JEVS_CAM_STATS
Outdated
| @@ -52,6 +52,7 @@ export COMINobs=${COMINobs:-$(compath.py ${envir}/com/obsproc/${obsproc_ver})} | |||
| export COMOUT=${COMOUT:-$(compath.py ${NET}/${evs_ver}/${STEP}/${COMPONENT}/${RUN})} | |||
| export COMOUTsmall=${COMOUTsmall:-$(compath.py ${NET}/${evs_ver}/${STEP}/${COMPONENT}/${RUN}.${VDATE}/${MODELNAME}/${VERIF_CASE})} | |||
| export COMOUTfinal=${COMOUTfinal:-$(compath.py ${NET}/${evs_ver}/${STEP}/${COMPONENT}/${MODELNAME}.${VDATE})} | |||
| mkdir -p $COMOUTfinal | |||
There was a problem hiding this comment.
This is a good start, but the mkdir command needs to be for $COMOUT specifically. See examples in $PACKAGEROOT for other models or networks. The reason is b/c COMOUTsmall and COMOUTfinal depend on the existence of COMOUT (COMOUT is in their parent path). COMOUTsmall and COMOUTfinal do not need to be created at the J-job level. Downstream scripting properly creates those dirs before there are any attempts to write to them (lines 103 and 108 of exevs_nam_firewxnest_grid2obs_stats.sh).
It also does not hurt to adopt the NCO option of "-m 775". So I suggest line 55 should be:
mkdir -m 775 -p $COMOUT
There was a problem hiding this comment.
I changed the mkdir line to this specification.
I don't see the pycache directory at all in the ush directory:
https://github.com/PerryShafran-NOAA/EVS/tree/feature/firewx/ush/cam
Perry
|
Great! I see the update to JEVS_CAM_STATS. |
|
The PR is now approved and merged! |
…ectory exists, fix 2 typos in sub-domain names in href plot script files (#398) * remove met_v in all plotting scripts * remove met_v from sref's ecf scripts * remove met_v from sref's ecf scripts * avoid mkdir for existing directory and 2 typos * fix one typo in scripts/plots/cam/exevs_href_profile_plots.sh * Update PointStat_fcstSREF_obsPREPBUFR_cnv.conf to select one from multiple fields * address EVS v1.0 Issues #31 and #32 * Updating metar config file to check for 3hr cycle frequency. --------- Co-authored-by: Shelley Melchior <Shelley.Melchior@noaa.gov>
Pull Request Testing
Extensive daily testing of the system
[X ] Has the code been checked to ensure that no errors occur during the execution? [Yes or No]
Do these updates/additions include sufficient testing updates? [Yes or No]
Please complete this pull request review by [Fill in date].
Pull Request Checklist
[ X] Review the source issue metadata (required labels, projects, and milestone).
[X ] Complete the PR description above.
[ X] Ensure the PR title matches the feature branch name.
Check the following:
[ X] Instructions provided on how to run
[X ] Developer's name is replaced by ${user} where necessary throughout the code
[ X] Check that the ecf file has all the proper definitions of variables
[X ] Check that the jobs file has all the proper settings of COMIN and COMOUT and other input variables
[ X] Check to see that the output directory structure is followed
[ X] Be sure that you are not using MET utilities outside the METplus wrapper structure
After submitting the PR, select Development issue with the original issue number.
After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
Close the linked issue.