EVSTC for V1.0 #46
EVSTC for V1.0 #46
Conversation
|
The test data is located on Dogwood: /lfs/h2/emc/vpppg/noscrub/jiayi.peng/MetTCData |
1 similar comment
|
The test data is located on Dogwood: /lfs/h2/emc/vpppg/noscrub/jiayi.peng/MetTCData |
|
Getting started on this PR, as a continuation/extension/replacement of PR #31, which was submitted back on Nov 3. |
|
The global_det and global_ens stats and plots components run to success and produce expected graphics. The plots and stats files are located in the appropriate EVS directory structure. Onto testing the regional side. |
|
The regional stats and plots components run to success and produce the expected graphics. The plots and stats files are located in the appropriate EVS directory structure. Various plots from global_det, global_ens, and regional were cp'd to rzdm for review. |
|
I am still not wild about the notation used in the J-job scripts for the default COMIN directory locations. Should someone ever run the ecf scripts with those variables unset (perhaps inadvertently commented out), the processing will break b/c, for example, |
|
@JiayiPeng-NOAA , before I can merge this PR, I need to reconcile conflicts in |
|
Hi Shelley,
That's the version number with the final dot.
Thanks,
Jiayi
…On Wed, Dec 14, 2022 at 12:59 PM Shelley Melchior ***@***.***> wrote:
@JiayiPeng-NOAA <https://github.com/JiayiPeng-NOAA> , before I can merge
this PR, I need to reconcile conflicts in versions/run.ver. The run.ver
file in the auth repo is more comprehensive than what you have in your PR,
as is expected. I need clarity on one item in your run.ver file.
export libfabric_ver=1.11.0.0.
Is that final dot supposed to be there? I think so, but I just want to
make sure.
—
Reply to this email directly, view it on GitHub
<#46 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRTVNMTSITNGTGYGFC7APTWNIDJHANCNFSM6AAAAAAS4KZ4HE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
This PR is ready for merge. But there are 2 items of note:
- formally address a more meaningful substitute for default COMIN paths rather than the current pseudo-code paths in the J-job scripts.
- Make sure the binary shapefiles and logo graphics are not carried in the repository and instead in a fixed location on disk. I understand they are included in the PR for the purposes of testing, but this cannot be the long term solution.
Pull Request Testing
Describe testing already performed for this Pull Request:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Has the code been checked to ensure that no errors occur during the execution? [Yes or No]
Do these updates/additions include sufficient testing updates? [Yes or No]
Please complete this pull request review by [Fill in date].
Pull Request Checklist
Review the source issue metadata (required labels, projects, and milestone).
Complete the PR description above.
Ensure the PR title matches the feature branch name.
Check the following:
Instructions provided on how to run
Developer's name is replaced by ${user} where necessary throughout the code
Check that the ecf file has all the proper definitions of variables
Check that the jobs file has all the proper settings of COMIN and COMOUT and other input variables
Check to see that the output directory structure is followed
Be sure that you are not using MET utilities outside the METplus wrapper structure
After submitting the PR, select Development issue with the original issue number.
After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
Close the linked issue.