Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/rm_PBS_V #525

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

malloryprow
Copy link
Contributor

@malloryprow malloryprow commented Aug 22, 2024

Note to developers: You must use this PR template!

Description of Changes

NCO does not want jobs running with #PBS -V. Some developers have removed it from their dev driver scripts, and this PR removes the remaining instances. Closes #464.

Developer Questions and Checklist

  • Is this a high priority PR? If so, why and is there a date it needs to be merged by?

No

  • Do you have any planned upcoming annual leave/PTO?

No

  • Are there any changes needed for when the jobs are supposed to run?

No

  • The code changes follow NCO's EE2 Standards.
  • Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • References the feature branch for HOMEevs are removed from the code.
  • J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • Jobs over 15 minutes in runtime have restart capability.
  • If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • Jobs contain the approriate file checking and don't run METplus for any missing data.
  • Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.

Testing Instructions

I don't think any testing is necessary but we can test a few jobs if desired.

Copy link

@AndrewBenjamin-NOAA AndrewBenjamin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the remaining instances of -V in the code.

@PerryShafran-NOAA
Copy link
Contributor

@malloryprow I really don't see the need for any testing, but would you like to see a few of these tested?

@malloryprow
Copy link
Contributor Author

Nope! I don't see the need for testing either!

@PerryShafran-NOAA
Copy link
Contributor

OK, then, I'll go ahead and approve.

Copy link
Contributor

@PerryShafran-NOAA PerryShafran-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No testing needed. Approved for merge.

@PerryShafran-NOAA PerryShafran-NOAA merged commit f038903 into NOAA-EMC:develop Aug 22, 2024
@malloryprow malloryprow deleted the feature/rm_PBS_V branch August 22, 2024 12:49
@malloryprow malloryprow added this to the EVS v2.0.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "PBS -V" from dev driver scripts
3 participants