Make separate JCB algorithm YAMLs for CI tests #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
DavidNew-NOAA
requested review from
CoryMartin-NOAA,
danholdaway,
RussTreadon-NOAA and
guillaumevernieres
danholdaway
previously approved these changes
Dec 2, 2024
|
@danholdaway Interesting idea. Let me give that a try |
guillaumevernieres
previously approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks @DavidNew-NOAA . That should fix the issue that we have when testing the 3dfgat in static and hybrid mode, it currently points to the same ref file.
DavidNew-NOAA
dismissed stale reviews from guillaumevernieres and danholdaway
via
8c0dd32
|
@danholdaway OK, I implemented your suggestion |
DavidNew-NOAA
requested review from
guillaumevernieres,
danholdaway and
DavidHuber-NOAA
DavidHuber-NOAA
approved these changes
Dec 2, 2024
CoryMartin-NOAA
approved these changes
Dec 2, 2024
|
I did approve, but that was with the understanding that we should be running the gdasapp test @DavidNew-NOAA . Are these broken? I see that the label I set in my pr has not been updated. |
|
@guillaumevernieres I'm actually refactoring and testing those scripts right now, so they won't work right now with the CI labels. I wasn't aware anyone was using those scripts currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for having separate JCB algorithm YAMLs for each CI test is that in the future, we may want different regression tests for various resolutions, obs configurations, etc. The primary JCB algorithm YAMLs should be generic.