Feature/nick e gpsro bufr #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasesposito
requested review from
CoryMartin-NOAA,
emilyhcliu,
ADCollard,
PraveenKumar-NOAA,
BrettHoover-NOAA and
XuanliLi-NOAA
CoryMartin-NOAA
approved these changes
Nov 14, 2023
CoryMartin-NOAA
pushed a commit
that referenced
this pull request
Nov 20, 2023
Updating GNSSRO converter and adding the yaml file to GDASApp end-to-end testing based on [#712](#712). New file: parm/atm/obs/config/gnssro.yaml: Added QC filters in the YAML Updated files: parm/ioda/bufr2ioda/bufr2ioda_gnssro_bufr.json: Updated the satellite information ush/ioda/bufr2ioda/bufr2ioda_gnssro_bufr.py: Updated pccf, qfro, and satelliteAscending flag Refer to [issue #750](#750) for testing details. JEDI/GSI comparisons revealed a cutoff near obs=0.03 Rad due to super refraction 2. The number of observations after QC in JEDI is also inconsistent with GSI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the GPS-RO bufr data converter (using the python api) to the GDASApp.
The two files added are:
~/ush/ioda/bufr2ioda/bufr2ioda_gpsro_bufr_combined.py
~/parm/ioda/bufr2ioda/bufr2ioda_gpsro_bufr_combined.json
This is validated in T20 issue #68