Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regression Test For HAFSv1 #600

Closed
JingCheng-NOAA opened this issue Jul 27, 2023 · 0 comments · Fixed by #646
Closed

Add Regression Test For HAFSv1 #600

JingCheng-NOAA opened this issue Jul 27, 2023 · 0 comments · Fixed by #646
Assignees

Comments

@JingCheng-NOAA
Copy link
Contributor

JingCheng-NOAA commented Jul 27, 2023

There should be at least four set of regression tests for the current suite of HAFSv1 GSI:

  1. 3DEnvar with GDAS Ensemble plus FGAT capability.
  2. 4Denvar with GDAS Ensemble plus FGAT capability.
  3. Self-cycled 3Envar with HAFS Ensemble.
  4. Self-cycled 3Envar with GDAS Ensemble plus HAFS Ensemble.
    The test case should be on smaller grid with limited number of ensemble members included.
@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue Jul 28, 2023
3 tasks
ShunLiu-NOAA pushed a commit that referenced this issue Oct 27, 2023
Add HAFS related regression test into GSI Ctests to solve the issue
#600.

Four set of regression tests for the current suite of HAFSv1 GSI:

3DEnvar with GDAS Ensemble plus FGAT capability --
"hafs_3denvar_glbens".
4Denvar with GDAS Ensemble plus FGAT capability --
"hafs_4denvar_glbens".
3Envar with self-cycled HAFS Ensemble -- "hafs_3denvar_hafens".
3Envar with GDAS Ensemble plus self-cycled HAFS Ensemble --
"hafs_3denvar_hybens".

Fixes #600 
Partially fixes #647 

**Type of change**

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

**How Has This Been Tested?**

These changes are tested under Orion through GSI Ctests.
  
**Checklist**

- [x ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] New and existing tests pass with my changes
- [x] Any dependent changes have been merged and published

**DUE DATE for this PR is 12/4/2023.** If this PR is not merged into
`develop` by this date, the PR will be closed and returned to the
developer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant