Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to allow for contrib modules to still load on Hera #11

Conversation

CoryMartin-NOAA
Copy link
Contributor

From Leslie Hart
The current method of loading "sutils" module:
module load contrib
module load sutils

The new method for loading “sutils” module (available now, and required starting 6/11/20):
module use -a /contrib/sutils/modulefiles
module load sutils

GSI modulefile for Hera has been modified to support these changes

@RussTreadon-NOAA RussTreadon-NOAA self-requested a review June 11, 2020 18:41
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@RussTreadon-NOAA RussTreadon-NOAA merged commit e9e717a into NOAA-EMC:release/gfsda.v16.0.0 Jun 11, 2020
@CoryMartin-NOAA CoryMartin-NOAA deleted the bugfix/contrib_hera branch June 11, 2020 19:21
lbi2018 referenced this pull request in lbi2018/GSI Mar 4, 2022
When running this regional_ensda branch for FV3-CAM tm06-coldstart hybrid DA, it was found the conversion subroutines like fv3_h_to_ll in "mod_fv3_lola.f90 was incorrectly used when the correct one should be , for example, fv3_h_to_ll_regular_grids in mod_fv3_lolgrid.f90. The incorrect use occurred in the subroutine called when fv3sar_bg_opt=1 ( on tm06 for tm06-coldstart exp for fv3-cam hybrid runs) and the newly merged gsi_fv3ncdf_write_fv3_dz subroutine. They should not have any impacts on HAFL's runs ( the problem would cause real time aborting rather than different results).
Another change is to use crtm/2.3.1 from Mike Lueken to avoid GSI abortion when running on debug mode.
The third ones are a couple of un-initialized variables in get_gefs_for_regional.f90. Li Bi already add those into the GSI EMC master. The changes in this branch is just to avoid getting those minor changes from that upstream master and confine the PR to between regional_ensda and regional_ensda_fix1.
Contributor: TingLei-NOAA
hu5970 referenced this pull request in hu5970/GSI Mar 9, 2022
Use 2m T/Q as background for surface observations analysis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants