Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue NOAA-EMC/GSI#267. Corrected the OznMon and RadMon ports for S4 and Jet #269

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

DavidHuber-NOAA
Copy link
Collaborator

This corrects the port of the OznMon and RadMon to S4 and Jet. For OznMon, this adds the default global workflow TANKDIR template to the search path of find_cycle.pl and mk_err_rpt.sh. For RadMon, it points to a newer lmod initialization script. This addresses #267.

@MichaelLueken
Copy link
Contributor

@DavidHuber-NOAA Would you like for me to assign someone to review this, or is the work contained to just S4 and Jet, thus this PR is ready to be merged to the authoritative repository?

@DavidHuber-NOAA
Copy link
Collaborator Author

@MichaelLueken-NOAA The modification to find_cycle.pl and mk_err_rpt.sh will affect all machines running the OznMon. A review from @EdwardSafford-NOAA would be appreciated.

@MichaelLueken MichaelLueken linked an issue Dec 14, 2021 that may be closed by this pull request
Copy link
Contributor

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MichaelLueken
Copy link
Contributor

Since Ed has given his approval, and there are no changes to the source code, I will now merge this work into the authoritative repository

@MichaelLueken MichaelLueken changed the title Corrected the OznMon and RadMon ports for S4 and Jet GitHub Issue NOAA-EMC/GSI#267. Corrected the OznMon and RadMon ports for S4 and Jet Dec 14, 2021
@MichaelLueken MichaelLueken merged commit a62dec6 into NOAA-EMC:master Dec 14, 2021
@DavidHuber-NOAA DavidHuber-NOAA deleted the fix_mon_ports branch February 16, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix RadMon and OznMon S4 & Jet ports
3 participants