Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue NOAA-EMC/GSI#68. Switches assimilating Ta to Tb. #271

Closed
wants to merge 1 commit into from

Conversation

ScottSieron-NOAA
Copy link
Contributor

This PR switches from assimilating satellite microwave antenna temperature (Ta) observations to brightness temperatures (Tb). This required:

  • a function to apply the antenna correction to antenna temperatures
  • changing which mnemonic is read from bufr files

Another set of changes, required for accurate Tb assimilation, is adding the support for multiple versions of antenna correction coefficients (ACCoeffs), each of which is in a version of CRTM SpcCoeff files. This required

  • reading the satellite antenna correction version from the bufr file
  • checking for the existence of multiple versions of the SpcCoeff file for a given satellite/sensor
  • if a different version of ACCoeffs is used for a given observation, then remove this antenna correction, and then apply the first version of the antenna correction

Several regression tests failed, noted in the issue.

@MichaelLueken
Copy link
Contributor

Hi @ScottSieron-NOAA, Thanks for updating your issue with the regression test results and creating the PR. Please let me know who you would like to have review your changes, and I will assign them. If you have any questions about any of the steps that you have followed up to this point, please let me know.

Copy link
Contributor

@ADCollard ADCollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amsua_metop-a_v2.SpcCoeff.bin is not available in CRTMv2.3.0 as far as I can tell. So we cannot proceed with this pull request at present. Presumably this file is available in 2.4.0?

@HaixiaLiu-NOAA
Copy link
Contributor

The v2 SpcCoeff files are not in 2.4.0 yet so far. Already contacted Ben who will update us on this.

@emilyhcliu
Copy link
Contributor

This PR is combined with PR #350. This PR can be closed.

@MichaelLueken
Copy link
Contributor

As noted from @emilyhcliu above, these changes were brought into the authoritative repository via PR #350. PR #350 was merged to the authoritative repository on 05/03/2022 at c13361c, so I will now close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching from assimilating microwave antenna temperatures to brightness temperatures
5 participants