GitHub Issue NOAA-EMC/GSI#28. regression test for aerosol impacts on radiance. #32
Conversation
MichaelLueken
requested review from
CoryMartin-NOAA,
MichaelLueken,
dtkleist,
guoqing-noaa and
hu5970
regression/regression_var.sh
Outdated
| @@ -122,7 +123,7 @@ case $machine in | |||
|
|
|||
| export fixcrtm="/scratch1/NCEPDEV/da/Michael.Lueken/CRTM_REL-2.2.3/crtm_v2.2.3/fix_update" | |||
| export casesdir="/scratch1/NCEPDEV/da/Michael.Lueken/noscrub/CASES" | |||
| export ndate=$NDATE | |||
| export ndate=${NDATE:-/scratch2/NCEPDEV/nwprod/NCEPLIBS/utils/prod_util.v1.1.0/exec/ndate} | |||
There was a problem hiding this comment.
Is this necessary? Is prod_util not loaded by the regression tests?
regression/regression_var.sh
Outdated
| @@ -279,6 +283,7 @@ export gps_dtype="gps_bnd" | |||
| export regression_vfydir="$noscrub/regression" | |||
|
|
|||
| # Define debug variable - If you want to run the debug tests, set this variable to .true. Default is .false. | |||
| #export debug=".true." | |||
There was a problem hiding this comment.
Should this commented line be added?
There was a problem hiding this comment.
I believe it can be removed.
I added it just for convenience to switch in longer wall-time.
regression/global_C96_fv3aerorad.sh
Outdated
| esac | ||
|
|
||
| # Collect diagnostic files for obs types (groups) below | ||
| listall="modis_aod_terra modis_aod_aqua" |
There was a problem hiding this comment.
Is this correct? I thought diag_aero was set to false in the namelist? Do we need to save diag files for other obs types?
There was a problem hiding this comment.
I also feel it's not needed section, because the script exit after the GSI finished, line 291.
Since this script is based on global_C96_fv3aero.sh, so I kept the section about diagnostic files.
|
@weiwilliam you will also need to make changes to run the regression tests using CMake/ctest. |
MichaelLueken
changed the title
Add a regression test for aerosol impacts on radiance and bugfix for reading the external aerosol file.
Please see issue #28 for more detail