Intel 2022 updates #629
Merged
Intel 2022 updates #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
RussTreadon-NOAA
requested review from
DavidHuber-NOAA and
CatherineThomas-NOAA
DavidHuber-NOAA
suggested changes
Sep 25, 2023
DavidHuber-NOAA
approved these changes
Sep 25, 2023
|
Thanks @DavidHuber-NOAA |
|
@RussTreadon-NOAA I'll handle merging this for you as the 'handling reviewer'. Do you wish to wait for @CatherineThomas-NOAA to approve, or will my review + @DavidHuber-NOAA 's be sufficient? |
CoryMartin-NOAA
approved these changes
Sep 25, 2023
CatherineThomas-NOAA
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two types of bugs discovered when cycling
gsi.xandenkf.xwith intel/2022 in the global workflowgsi.xto be consistent with codes which read netcdf diagnostic fileslrun_subdirs=.true.option ofgsi.xto properly handle the case in which sub-directories already exist in the run directoryFixes #623
Type of change
How Has This Been Tested?
Ctests have been on Hera, Orion, and WCOSS2 (Cactus) with acceptable behavior. A global parallel covering the period 2021073106 through 2021080118 has been run on Hera, Orion, and WCOSS2 (Cactus). All global workflow jobs ran as expected.
Checklist