Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/logcleanup #20

Merged
merged 7 commits into from
Apr 9, 2020

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 9, 2020

Resolves issue #19

This PR is only for cleanup of error message handling in the nuopc_driver to improve code readability and reduce code length.

Regression test was run for cold and 1d benchmark cases. Full regression test suite was not run due to abnormally high Hera queue congestion.

Log report: rtreport.txt

Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you ran some regression tests and they passed. This definitely cleans things up! Thanks!

Copy link
Collaborator

@jiandewang jiandewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the newly defined function chkerr makes code much clean and easy to read, approve this PR.

@DeniseWorthen DeniseWorthen merged commit f8bc91c into NOAA-EMC:dev/emc Apr 9, 2020
DeniseWorthen added a commit to DeniseWorthen/MOM6 that referenced this pull request Apr 9, 2020
@DeniseWorthen
Copy link
Collaborator Author

@jiandewang would you go ahead and update MOM6-interface too? Thx.

@jiandewang
Copy link
Collaborator

jiandewang commented Apr 9, 2020 via email

@DeniseWorthen DeniseWorthen deleted the feature/logcleanup branch May 27, 2020 11:32
@DeniseWorthen DeniseWorthen restored the feature/logcleanup branch August 31, 2020 20:00
@DeniseWorthen DeniseWorthen deleted the feature/logcleanup branch January 15, 2021 16:38
jiandewang pushed a commit to jiandewang/MOM6 that referenced this pull request Jun 17, 2021
merge in latest dev/gfdl changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants