-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/logcleanup #20
Feature/logcleanup #20
Conversation
merge dev/emc
merge dev/emc
merge to latest dev/emc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust that you ran some regression tests and they passed. This definitely cleans things up! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the newly defined function chkerr makes code much clean and easy to read, approve this PR.
Feature/logcleanup (NOAA-EMC#20)
@jiandewang would you go ahead and update MOM6-interface too? Thx. |
Ok will do
On Thu, Apr 9, 2020 at 11:56 AM Denise Worthen ***@***.***> wrote:
@jiandewang <https://github.com/jiandewang> would you go ahead and update
MOM6-interface too? Thx.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMGAS4CDMWFBJTGXPQGJRDRLXVZDANCNFSM4MEU62XQ>
.
--
Jiande Wang
IMSG at NOAA/NWS/NCEP/EMC
cubic 2088
jiande.wang@noaa.gov
phone:3016833725
|
merge in latest dev/gfdl changes
Resolves issue #19
This PR is only for cleanup of error message handling in the nuopc_driver to improve code readability and reduce code length.
Regression test was run for cold and 1d benchmark cases. Full regression test suite was not run due to abnormally high Hera queue congestion.
Log report: rtreport.txt