Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two halo updates for taux and tauy in mom_surface_forcing_nuopc #49

Merged

Conversation

breichl
Copy link

@breichl breichl commented Jan 15, 2021

  • In A and B grid configuration halos were never updated after taux/tauy were populated.
  • This propagated through to the ustar_gustless field, hence caused a restart issue when using ustar_gustless in parameterizations.
  • This appears to correct the restart issue (restart reproducibility (without waves) when USE_LA_LI2016=True #46 ) by updating the halos at the end of the A and B grid taux/tauy loops.

- In A and B grid configuration halos were never updated after taux/tauy were populated.
- This propogated through to the ustar_gustless field, hence caused a restart issue when using ustar_gustless in parameterizations.
- This appears to correct the restart issue by updating the halos at the end of the A and B grid taux/tauy loops.
@jiandewang
Copy link
Collaborator

look good to me, will wait for confirmation from Denise on her RT runs

@DeniseWorthen
Copy link
Collaborator

@jiandewang I have tested on orion and I can report that:

  1. this fix does not change existing non-benchmark baselines. So the fix has no impact unless we have USE_LA_LI2016=TRUE

  2. this fix allows all non-wave benchmark tests to restart reproduce when used with USE_LA_LI2016=TRUE

@jiandewang
Copy link
Collaborator

@DeniseWorthen this means there is no need to create new baseline, right ?

@DeniseWorthen
Copy link
Collaborator

@jiandewang We want the benchmark RTs to track as closely as possible the benchmark configuration. The benchmarks use USE_LA_LI2016=TRUE but since waves are not restart repro, we set this variable false in the non-wave benchmark RTs. This allowed us to test and maintain restart repro for the non-wave benchmark config.

Now that we can set it true and still maintain restart repro, we want to modify the non-wave benchmark RTs to use it. This will change the baselines for all non-wave benchmark tests.

@jiandewang
Copy link
Collaborator

@DeniseWorthen got what you mean, so with this fixing we can set USE_LA_LI2016 to T for all RT cases. I am going to approval this PR. Thanks for you, Jessica and Brandon's quick work.

Copy link
Collaborator

@jiandewang jiandewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fixing solved the restart repro issue.

@jiandewang jiandewang merged commit cec1ad3 into NOAA-EMC:dev/emc Jan 17, 2021
jiandewang pushed a commit to jiandewang/MOM6 that referenced this pull request Jun 17, 2021
jiandewang pushed a commit to jiandewang/MOM6 that referenced this pull request Apr 5, 2022
  Renamed the framework module MOM_scaling_check.F90 to MOM_unique_scales.F90 to
help differentiate it from MOM_check_scaling.F90, and renamed the subroutine
check_scaling_factors() as check_scaling_uniqueness().  Also added
_Dimensional_consistency.dox to describe the dimensional consistency testing.
This commit should address the issues raised in the review of MOM6 PR NOAA-EMC#49.  All
answers and output are bitwise identical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants