-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two halo updates for taux and tauy in mom_surface_forcing_nuopc #49
Add two halo updates for taux and tauy in mom_surface_forcing_nuopc #49
Conversation
breichl
commented
Jan 15, 2021
- In A and B grid configuration halos were never updated after taux/tauy were populated.
- This propagated through to the ustar_gustless field, hence caused a restart issue when using ustar_gustless in parameterizations.
- This appears to correct the restart issue (restart reproducibility (without waves) when USE_LA_LI2016=True #46 ) by updating the halos at the end of the A and B grid taux/tauy loops.
- In A and B grid configuration halos were never updated after taux/tauy were populated. - This propogated through to the ustar_gustless field, hence caused a restart issue when using ustar_gustless in parameterizations. - This appears to correct the restart issue by updating the halos at the end of the A and B grid taux/tauy loops.
look good to me, will wait for confirmation from Denise on her RT runs |
@jiandewang I have tested on orion and I can report that:
|
@DeniseWorthen this means there is no need to create new baseline, right ? |
@jiandewang We want the benchmark RTs to track as closely as possible the benchmark configuration. The benchmarks use Now that we can set it true and still maintain restart repro, we want to modify the non-wave benchmark RTs to use it. This will change the baselines for all non-wave benchmark tests. |
@DeniseWorthen got what you mean, so with this fixing we can set USE_LA_LI2016 to T for all RT cases. I am going to approval this PR. Thanks for you, Jessica and Brandon's quick work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fixing solved the restart repro issue.
Merge in updates from dev/gfdl
Renamed the framework module MOM_scaling_check.F90 to MOM_unique_scales.F90 to help differentiate it from MOM_check_scaling.F90, and renamed the subroutine check_scaling_factors() as check_scaling_uniqueness(). Also added _Dimensional_consistency.dox to describe the dimensional consistency testing. This commit should address the issues raised in the review of MOM6 PR NOAA-EMC#49. All answers and output are bitwise identical.