Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bacio.c has some C functions that are never called from Fortran and can be removed... #53

Closed
edwardhartnett opened this issue Oct 7, 2021 · 2 comments · Fixed by #61
Assignees
Labels
enhancement New feature or request

Comments

@edwardhartnett
Copy link
Contributor

In bacio.c we have four functions:

bacio()
banio()
baciol()
baniol()

The bacio functions are then called from Fortran.

But the banio functions are not called from anywhere. I rather think that no one is using the C interface to banio - it's very clumsy. So I suspect the banio functions can be removed.

@edwardhartnett edwardhartnett added the enhancement New feature or request label Oct 7, 2021
@edwardhartnett edwardhartnett self-assigned this Oct 7, 2021
@edwardhartnett
Copy link
Contributor Author

I contacted Robert Grumbine, the original author of the code. His email confirms that this code is not used by any of our Fortran codes, so can safely be removed:

Hi Ed,

Yes, I remember writing the C side of bacio, back in the days we were getting off the Cray UNICOS systems. Mark Iredell was doing the Fortran. At the time I was one of the few, perhaps only, people in EMC who knew C.

Banio/Baniol was my addition for numeric (hence n) rather than c (character/byte) based io. I think the only person who used it was me, and I'd quit using it in operations by the early 2000s. If anyone else started using it, I never heard about it.

Am I remembering names correctly -- you gave a session on unit testing a while back?

Cheers,
Bob

@edwardhartnett
Copy link
Contributor Author

Removing the banio helps out test coverage a lot!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant