Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused code #61

Merged
merged 2 commits into from
Oct 7, 2021
Merged

removed unused code #61

merged 2 commits into from
Oct 7, 2021

Conversation

edwardhartnett
Copy link
Contributor

Fixes #53

Remove the unused banio functions.

@BrianCurtis-NOAA
Copy link

Why is *size getting removed ? Was it always 1? If it wasn't I am just guessing it would change the number a bit and shouldn't be removed.

@edwardhartnett
Copy link
Contributor Author

Actually what is happening is that the github output is confusing.

There were four functions in the file, all almost identical.

bacio
banio
baciol
baniol

I removed banio and baniol, and it seems to be showing that as if I made a bunch of changes in baniol.

Take a look at the whole file and you will see that bacio/baciol are untouched, and banio/baniol are gone.

@BrianCurtis-NOAA
Copy link

Thanks for that pointer. To code was so similar the diff threw me off.

@edwardhartnett edwardhartnett merged commit 6f78490 into develop Oct 7, 2021
@edwardhartnett edwardhartnett deleted the ejh_remove_banio branch October 7, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bacio.c has some C functions that are never called from Fortran and can be removed...
2 participants