update spack file #783
Closed
update spack file #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
requested review from
AlexanderRichert-NOAA and
Hang-Lei-NOAA
|
Where are you seeing the AEC-related lines? |
|
In this PR I just plonked the package file from the main spack repo on top of the repo's package file. As you can see in code review, this wipes out a few lines of package file code relating to AEC. |
|
Ah okay I see it now. Yes we'll want to restore that. |
|
@AlexanderRichert-NOAA I have tried but cannot figure out how this is breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #782
I wish I had caught this before I merged the last PR, but I didn't...
This seems to wipe out a few lines about AEC in the repo version of the spack package file. @AlexanderRichert-NOAA what do we want to do, keep these?