check code format in CI #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
requested review from
DusanJovic-NOAA,
AlexanderRichert-NOAA,
AlysonStahl-NOAA and
Hang-Lei-NOAA
DusanJovic-NOAA
approved these changes
Oct 29, 2024
Hang-Lei-NOAA
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
This is of interest to any code manager with C code.
In this PR, at @DusanJovic-NOAA suggestion, I add clang-format to check code format before merging.
Note that the CI does not automatically format code, it just detects when code is badly formatted. Use clang-format locally to reformat any failing code.
Code must comply with clang-format-18 (which is what is currently available for ubuntu-24). Earlier versions of clang-format have an annoying bug that is activated in g2c code, so clang-format-18 is the earliest version that works.
In order to get clang-format-18 I had to change the image to ubuntu-24.04 in the developer workflow. However, soon this will be ubuntu-latest.
Updating the version of ubuntu also updated the version of doxygen, leading to some new doxygen warnings, which I fixed by running doxygen -u on the Doxyfile.in.
No code changes in this PR, just formatting.