Change gbyte to g2_gbytec in cnvgrib #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbyte comes from w3emc and operates on words, while g2_gbytec operates on individual bytes and is how cnvgrib passes arguments to the function. gbytec originally came from g2, but the name was changed to g2_gbytec, and w3emc happened to have the same function name, so no error was generated about a missing symbol. This function is only called when using an ensemble template, so it was never noticed.
Hang-Lei-NOAA
approved these changes
Mar 22, 2022
|
Awesome catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gbyte comes from w3emc and operates on words, while g2_gbytec operates on individual bytes and is how cnvgrib passes arguments to the function. gbytec originally came from g2, but the name was changed to g2_gbytec, and w3emc happened to have the same function name, so no error was generated about a missing symbol. This function is only called when using an ensemble template, so it was never noticed.
Fix #138