moved test data to subdirectory "data", allow user to specify local data directory to find FTP files, added some test files for future testing #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
changed the title
edwardhartnett
changed the title
edwardhartnett
requested review from
AlexanderRichert-NOAA and
Hang-Lei-NOAA
|
More work to be done with these tests but this is a good point to commit these. Further improvement will happen incrementally... |
Hang-Lei-NOAA
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More testing with FTP files.
In this PR I move the test data to a subdirectory called data under tests.
Also allow the builder to specify a local data directory to find the FTP data files, so developers don't have to keep downloading them.
Also added a bunch of test file output from degrib2 and grb2index for our new FTP test files. These test data files will be used in new testing.
Part of #116
Fixes #183
Fixes #182