-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copygb, copygb2 testing #242
Update copygb, copygb2 testing #242
Conversation
56fca5a
to
8b4bea6
Compare
8a53949
to
fbb1499
Compare
wgrib output of 172.land.grib1 from copygb when using w3emc 2.9.3:
wgrib output of 172.land.grib1 from copygb when using w3emc 2.10.0:
|
@edwardhartnett per my above comment, when copygb regrids an input file, it gives different results for one of the test files depending on which version of w3emc is used. Note the differences for 'Lat1' and 'Orient'. Does this indicate that one or the other version of w3emc is doing something wrong, or does this come down to different valid choices that can be made in the regridding process? |
@GeorgeGayno-NOAA do you know the answer to @AlexanderRichert-NOAA 's question? I sure don't... |
The definition of grids 172 and 220 was updated. NOAA-EMC/NCEPLIBS-w3emc#157 |
OK, so it looks like we want to change the test to accept the answer from the current version of w3emc, and we can stop testing with older versions. We should also change the grib_util main cmake file so that it requires the latest release of w3emc. |
src/copygb/copygb.F90
Outdated
@@ -1190,7 +1190,7 @@ END SUBROUTINE INTGRIB | |||
SUBROUTINE INTGRIB1(K1F,KGDS1F,K2F,KGDS2F,MRL,MRO, & | |||
IV,IP,IPOPT,KGDS1,K1,IB1,L1,F1,G1,KGDS2,K2, & | |||
IB2,L2,F2,G2,IRET) | |||
USE IP_MOD | |||
! USE IP_MOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been doing a lot of fiddling in investigating CI issues, so this is related to restesting with the older ip version. I'm currently trying to figure why the intel version is segfaulting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sorry I didn't notice that this was a draft PR.
Extend/reinstate copygb+copygb2 testing to include interp functionality. Move to ip 4.x.
Fixes #93
Addresses #116