Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copygb, copygb2 testing #242

Conversation

AlexanderRichert-NOAA
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Jul 21, 2023

Extend/reinstate copygb+copygb2 testing to include interp functionality. Move to ip 4.x.

Fixes #93
Addresses #116

@AlexanderRichert-NOAA AlexanderRichert-NOAA force-pushed the copygb_testing branch 3 times, most recently from 8a53949 to fbb1499 Compare July 21, 2023 22:42
@AlexanderRichert-NOAA
Copy link
Contributor Author

wgrib output of 172.land.grib1 from copygb when using w3emc 2.9.3:

rec 1:0:date 2022122000 LAND kpds5=81 kpds6=1 kpds7=0 levels=(0,0) grid=172 sfc 24hr fcst:
  LAND=Land cover (land=1;sea=0) [fraction]
  timerange 10 P1 0 P2 24 TimeU 1  nx 690 ny 710 GDS grid 5 num_in_ave 0 missing 0
  center 7 subcenter 0 process 96 Table 2 scan: WE:SN winds(N/S) 
  polar stereo: Lat1 -36.866000 Long1 -220.194000 Orient -260.000000
     south pole (690 x 710) Dx 12700 Dy 12700 scan 64 mode 0
  min/max data 0 1  num bits 1  BDS_Ref 0  DecScale 0 BinScale 0

wgrib output of 172.land.grib1 from copygb when using w3emc 2.10.0:

rec 1:0:date 2022122000 LAND kpds5=81 kpds6=1 kpds7=0 levels=(0,0) grid=172 sfc 24hr fcst:
  LAND=Land cover (land=1;sea=0) [fraction]
  timerange 10 P1 0 P2 24 TimeU 1  nx 690 ny 710 GDS grid 5 num_in_ave 0 missing 0
  center 7 subcenter 0 process 96 Table 2 scan: WE:SN winds(N/S) 
  polar stereo: Lat1 -36.899000 Long1 -220.194000 Orient -80.000000
     south pole (690 x 710) Dx 12700 Dy 12700 scan 64 mode 0
  min/max data 0 1  num bits 1  BDS_Ref 0  DecScale 0 BinScale 0

@AlexanderRichert-NOAA
Copy link
Contributor Author

@edwardhartnett per my above comment, when copygb regrids an input file, it gives different results for one of the test files depending on which version of w3emc is used. Note the differences for 'Lat1' and 'Orient'. Does this indicate that one or the other version of w3emc is doing something wrong, or does this come down to different valid choices that can be made in the regridding process?

@edwardhartnett
Copy link
Contributor

@GeorgeGayno-NOAA do you know the answer to @AlexanderRichert-NOAA 's question? I sure don't...

@GeorgeGayno-NOAA
Copy link
Contributor

@edwardhartnett per my above comment, when copygb regrids an input file, it gives different results for one of the test files depending on which version of w3emc is used. Note the differences for 'Lat1' and 'Orient'. Does this indicate that one or the other version of w3emc is doing something wrong, or does this come down to different valid choices that can be made in the regridding process?

The definition of grids 172 and 220 was updated. NOAA-EMC/NCEPLIBS-w3emc#157

@edwardhartnett
Copy link
Contributor

OK, so it looks like we want to change the test to accept the answer from the current version of w3emc, and we can stop testing with older versions.

We should also change the grib_util main cmake file so that it requires the latest release of w3emc.

@@ -1190,7 +1190,7 @@ END SUBROUTINE INTGRIB
SUBROUTINE INTGRIB1(K1F,KGDS1F,K2F,KGDS2F,MRL,MRO, &
IV,IP,IPOPT,KGDS1,K1,IB1,L1,F1,G1,KGDS2,K2, &
IB2,L2,F2,G2,IRET)
USE IP_MOD
! USE IP_MOD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been doing a lot of fiddling in investigating CI issues, so this is related to restesting with the older ip version. I'm currently trying to figure why the intel version is segfaulting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sorry I didn't notice that this was a draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle change in ip library after 3.3.3
3 participants