Update spack recipe #321
Open
Update spack recipe #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hang-Lei-NOAA
approved these changes
Mar 26, 2024
| @@ -31,6 +33,7 @@ class GribUtil(CMakePackage): | |||
| depends_on("w3emc precision=4,d", when="^w3emc@2.10:") | |||
| depends_on("w3nco", when="@:1.2.3") | |||
| depends_on("g2") | |||
| depends_on("g2@3.4.9:", when="@1.4:") | |||
There was a problem hiding this comment.
Not sure how much it matters, but 1.3 depended on g2-3.4.8.
So I think you want to add:
depends_on("g2@3.4.8:", when="@1.3:")
| @@ -18,6 +18,8 @@ class GribUtil(CMakePackage): | |||
| maintainers("AlexanderRichert-NOAA", "Hang-Lei-NOAA", "edwardhartnett") | |||
|
|
|||
| version("develop", branch="develop") | |||
| version("1.4.0", tag="v1.4.0", commit="eeacc9ec93dfe6379f576191883c84a4a1202cc8") | |||
| version("1.3.0", commit="9d3c68a") | |||
There was a problem hiding this comment.
How come these are different? In other words, why not use the v1.3.0 tag?
|
@AlexanderRichert-NOAA thank you for doing these! |
|
Should this be merged, or closed? |
|
Sorry, this fell off my radar. I'll update shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the spack recipe.