Remove NCEPLIBS from CI, build individual packages instead, add address sanitizer, documentation build, and code coverage #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
changed the title
edwardhartnett
changed the title
edwardhartnett
requested review from
kgerheiser,
BrianCurtis-NOAA and
Hang-Lei-NOAA
|
This is ready to merge... |
| # project. | ||
| # | ||
| # Ed Hartnett | ||
|
|
There was a problem hiding this comment.
Are you adding the tests here or to another PR?
There was a problem hiding this comment.
Another PR. But this PR at least allows make test to succeed (with no tests), so that the CI can start calling make test...
BrianCurtis-NOAA
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of getting the NCEPLIBS project and building it in CI, get the specific packages we need from NCEPLIBS.
Also use caching in the CI, which was not being used for some reason...
Fixes #64