Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new workflow that tests develop branch of dependent libraries #92

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

edwardhartnett
Copy link
Contributor

Fixes #91

adding new workflow that tests develop branch of dependent libraries

@edwardhartnett
Copy link
Contributor Author

@kgerheiser should grib_utils build with the current develop branch of ip?

It is failing to find a function. Is that because of the merge with ip2?

/usr/bin/ld: CMakeFiles/copygb.dir/copygb.F.o: in function `intgrib1_':
/home/runner/work/NCEPLIBS-grib_util/NCEPLIBS-grib_util/grib_utils/src/copygb/copygb.F:1222: undefined reference to `ipolates_'


@kgerheiser
Copy link
Contributor

That's exactly what it is. You can use v3.3.3, or add use ip_mod for develop.

@edwardhartnett
Copy link
Contributor Author

OK, so every NCEPLIBS library (and other user) that uses ip needs to change their build system to cope with this. ;-)

@kgerheiser
Copy link
Contributor

Not the build system, but the actual code.

@edwardhartnett
Copy link
Contributor Author

edwardhartnett commented Dec 15, 2021

Right, but the build system also, because that use statement can't be used with older versions of ip.

So either the build system demands version 3.4.0 or greater, or uses a pre-processor flag and some ifdef magic to include the use statement only if version >= 3.4.0.

When are we going to release ip-3.4.0? Seems like we need to, so that grib_util and other utilities can test against the new way of doing ip.

@edwardhartnett
Copy link
Contributor Author

OK, the ip problem still needs to be resolved, so I change ip to 3.3.0 in the CI. This PR is ready to merge.

@edwardhartnett edwardhartnett merged commit 4ba416c into develop Dec 15, 2021
@edwardhartnett edwardhartnett deleted the ejh_bacio_2 branch December 15, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add CI workflow that tests against develop branch of dependent NCEPLIBS libraries
3 participants