-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new workflow that tests develop branch of dependent libraries #92
Conversation
@kgerheiser should grib_utils build with the current develop branch of ip? It is failing to find a function. Is that because of the merge with ip2?
|
That's exactly what it is. You can use v3.3.3, or add |
OK, so every NCEPLIBS library (and other user) that uses ip needs to change their build system to cope with this. ;-) |
Not the build system, but the actual code. |
Right, but the build system also, because that use statement can't be used with older versions of ip. So either the build system demands version 3.4.0 or greater, or uses a pre-processor flag and some ifdef magic to include the use statement only if version >= 3.4.0. When are we going to release ip-3.4.0? Seems like we need to, so that grib_util and other utilities can test against the new way of doing ip. |
OK, the ip problem still needs to be resolved, so I change ip to 3.3.0 in the CI. This PR is ready to merge. |
Fixes #91
adding new workflow that tests develop branch of dependent libraries