Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change w3nco to w3emc #33

Closed
edwardhartnett opened this issue Oct 22, 2020 · 4 comments · Fixed by #47
Closed

Change w3nco to w3emc #33

edwardhartnett opened this issue Oct 22, 2020 · 4 comments · Fixed by #47
Assignees
Labels
build documentation Improvements or additions to documentation

Comments

@edwardhartnett
Copy link
Contributor

In the README we say that nemsio needs bacio and w3nco.

But it only seems to require bacio when it builds. Is this expected?

@edwardhartnett
Copy link
Contributor Author

When I try and build nemsio for the UPP CI build, I get this:

CMake Error at CMakeLists.txt:37 (find_package):
31
  By not providing "Findw3nco.cmake" in CMAKE_MODULE_PATH this project has
32
-- Configuring incomplete, errors occurred!
33
  asked CMake to find a package configuration file provided by "w3nco", but
34
See also "/home/runner/work/EMC_post/EMC_post/nemsio/build/CMakeFiles/CMakeOutput.log".
35
  CMake did not find one.
36

37
  Could not find a package configuration file provided by "w3nco" with any of
38
  the following names:
39

40
    w3ncoConfig.cmake
41
    w3nco-config.cmake

Looking at nemsio I see there is no git submodule and also no Findwenco in the cmake directory.

In the CMakeLists.txt file I see:

find_package(bacio REQUIRED)
find_package(w3nco REQUIRED)

@edwardhartnett
Copy link
Contributor Author

I see this:

find .. -name CMakeLists.txt|xargs grep w3nco
../src/CMakeLists.txt:#depends on w3nco and bacio, but users must link their own version
../utils/CMakeLists.txt:target_link_libraries(nemsio_read nemsio bacio::bacio_4 w3nco::w3nco_d)
../utils/CMakeLists.txt:target_link_libraries(nemsio_get nemsio bacio::bacio_4 w3nco::w3nco_d)
../utils/CMakeLists.txt:target_link_libraries(nemsio_chgdate nemsio bacio::bacio_4 w3nco::w3nco_d)
../utils/CMakeLists.txt:target_link_libraries(mkgfsnemsioctl nemsio bacio::bacio_4 w3nco::w3nco_d)
../tests/CMakeLists.txt:target_link_libraries( ${exeName} PUBLIC nemsio bacio::bacio_4 w3nco::w3nco_d)
../tests/CMakeLists.txt:  LINK_LIBRARIES nemsio bacio::bacio_4 w3nco::w3nco_d
../CMakeLists.txt:find_package(w3nco REQUIRED)


So apparently it is needed for the build. However, it should now be changed to the emc version of this library.

@edwardhartnett edwardhartnett changed the title Does nemsio really need w3nco? Change w3nco to w3emc Apr 22, 2021
@kgerheiser
Copy link
Contributor

Need a release of w3emc with the combined library.

@edwardhartnett
Copy link
Contributor Author

OK, the w3emc release has happened, so we need to fix this and do a new release with the new dependency.

@edwardhartnett edwardhartnett self-assigned this Sep 20, 2021
@edwardhartnett edwardhartnett added build documentation Improvements or additions to documentation labels Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants