Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed to w3emc instead of w3nco #47

Merged
merged 5 commits into from
Sep 20, 2021
Merged

changed to w3emc instead of w3nco #47

merged 5 commits into from
Sep 20, 2021

Conversation

edwardhartnett
Copy link
Contributor

Part of #43
Fixes #33

Changed to depend on w3emc instead of w3nco.

Also check the version of w3emc for correctness.

Also cleaned up some cmake files.

Hang-Lei-NOAA
Hang-Lei-NOAA approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@Hang-Lei-NOAA Hang-Lei-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it implies that future nemsio version starts from using w3emc 2.9.0.

@edwardhartnett edwardhartnett mentioned this pull request Sep 20, 2021
Merged
@edwardhartnett
Copy link
Contributor Author

@Hang-Lei-NOAA yes, from the next release of nemsio onwards, release 2.9.0 or better of w3emc is required in the build.

@edwardhartnett edwardhartnett merged commit 781deec into develop Sep 20, 2021
@edwardhartnett edwardhartnett deleted the ejh_w3emc branch September 20, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hang-Lei-NOAA Hang-Lei-NOAA Hang-Lei-NOAA approved these changes

@kgerheiser kgerheiser Awaiting requested review from kgerheiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change w3nco to w3emc
2 participants
@edwardhartnett @Hang-Lei-NOAA