Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the changes from UPP for GFSV16 #421

Closed
WenMeng-NOAA opened this issue Dec 21, 2021 · 0 comments · Fixed by #422
Closed

Sync the changes from UPP for GFSV16 #421

WenMeng-NOAA opened this issue Dec 21, 2021 · 0 comments · Fixed by #422
Assignees

Comments

@WenMeng-NOAA
Copy link
Collaborator

Update the branch develop with the changes from UPP version for GFSV16:

  • Remove mange_externals for checking gtg code
  • Check out gtg code as submodule
  • Update GFS post workflow scripts with changes from GFSV16
@WenMeng-NOAA WenMeng-NOAA self-assigned this Dec 21, 2021
@WenMeng-NOAA WenMeng-NOAA linked a pull request Dec 21, 2021 that will close this issue
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
* Changing configuration to FV3_HRRR physics.

* Bug fix for setting GWD_HRRRsuite_BASEDIR when running the FV3_HRRR suite in NCO mode (NOAA-EMC#421)

@chunhuazhou (Chunhua Zhou) reported that GWD_HRRRsuite_BASEDIR is not getting set correctly when running the FV3_HRRR suite in NCO mode.  This PR is to fix that bug.

## DESCRIPTION OF CHANGES:

### Main changes:
* In setup.sh, ensure that GWD_HRRRsuite_BASEDIR is set properly when running the FV3_HRRR suite in NCO mode, and add checks to make sure directories exist, etc.
* Add 2 new WE2E tests for running the FV3_HRRR suite in NCO mode on the RRFS_CONUS_25km and RRFS_CONUS_3km grids.  The test names are nco_grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_HRRR and nco_grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_HRRR.  These run the 2020020800 case, which is a winter case that has a history of crashing.

### Improvements:
* Remove the regional_workflow/env directory since it is unused.
* Change the names of 5 of the existing NCO-mode WE2E tests to make it clearer what configurations they run (and to be consistent with the naming convention of community-mode tests).

## TESTS CONDUCTED:
Ran the following WE2E tests (including the two new ones) on Hera.  All were successful.
* grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_HRRR
* nco_grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_HRRR
* nco_grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_HRRR (both on 2020020800 and 2020081006)

* Path to GWD suite fix file needed.

* Adding a tag to each job name.

* Adding configurable reservation settings.

* Switch to 2 threads to reduce node count.

* Turn on the reservation.

Co-authored-by: gsketefian <31046882+gsketefian@users.noreply.github.com>
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant