Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #170 cloud fraction mod for FV3LAM #177

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

fossell
Copy link
Contributor

@fossell fossell commented Aug 27, 2020

Merge #170 mods to the release/public-v2 branch for SRW release. @ericaligo-NOAA - Can you please confirm your mods need to go into this branch/release? If yes, does this need to be tested by SRW team prior to merging this PR?

Copy link
Contributor

@ericaligo-NOAA ericaligo-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cld_amt was read in from the dyn file, but since that will be replaced by cldfra, which is read in from the phy file, we read in one less record (14 not 15) and we can eliminate the read of cld_amt.

@fossell
Copy link
Contributor Author

fossell commented Aug 31, 2020

@JeffBeck-NOAA - Did you or anyone else want to review this or are we good to go with merging in Eric's mods?

@JeffBeck-NOAA
Copy link
Contributor

@fossell Based on the email threads I've reviewed, I think we're ready to merge!

@fossell
Copy link
Contributor Author

fossell commented Aug 31, 2020

@JeffBeck-NOAA Great, thanks for confirming!

@fossell fossell merged commit ba89a7d into NOAA-EMC:release/public-v2 Aug 31, 2020
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants