Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for FV3 LAM/LAMX #219

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Bug fix for FV3 LAM/LAMX #219

merged 4 commits into from
Nov 10, 2020

Conversation

WenMeng-NOAA
Copy link
Collaborator

The changes:

  1. Bug fix for calculation of total cloud fraction for FV3 LAMX.
  2. Setting LSM physics as 2 for default in regional FV3 read interface.

ericaligo-NOAA
ericaligo-NOAA approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@ericaligo-NOAA ericaligo-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fossell
Copy link
Contributor

fossell commented Nov 9, 2020

@ericaligo-NOAA - Should this bug fix be going into the release/public-v2 branch as well for SRW release?

@WenMeng-NOAA
Copy link
Collaborator Author

@fossell These are two bug fixes for regional FV3. Please sync in release/public-v2.

@fossell
Copy link
Contributor

fossell commented Nov 9, 2020

@fossell These are two bug fixes for regional FV3. Please sync in release/public-v2.

@WenMeng-NOAA Thanks, I'll cherry pick this into public-v2 once merged into develop.

@WenMeng-NOAA
Copy link
Collaborator Author

The regression tests were conducted on Dell, Cray and Hera. With this PR, the baseline for FV3 LAM will be re-created. The FV3 LAM developer tested and verified the changes.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 4452859 into NOAA-EMC:develop Nov 10, 2020
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Nov 10, 2020
Closed
fossell pushed a commit to fossell/UPP that referenced this pull request Nov 10, 2020
@WenMeng-NOAA @fossell
Bug fix for FV3 LAM/LAMX (NOAA-EMC#219)
d3199e8 
* Fix of total cloud fraction in CLDRAD.f for FV3/LAMX.

* Setting  iSF_SURFACE_PHYSICS as 2 in regional FV3 read interface.
fossell added a commit that referenced this pull request Nov 10, 2020
@fossell
Merge pull request #221 from fossell/release/public-v2
bff872f 
Bug fix for FV3 LAM/LAMX (#219)
WenMeng-NOAA pushed a commit that referenced this pull request Dec 29, 2020
@JesseMeng-NOAA
UPP refactor phase 2 from Jesse Meng (#224)
29341ff 
* 20200820 Jesse Meng refactor branch of remove goto remove grib1

* 20200901 Jesse Meng remove redundant LAI output in SURFCE.f

* 20200901 Jesse Meng continue merging refactor to develop

* 20200911 Jesse Meng add precisions to selected variables

* 20200911 Jesse Meng revert the precision changes

* 20200924 Jesse Meng update with EMC_post/develop

* 20201105 Jesse Meng merge with NOAA-EMC/EMC_post PR#196
eed90f5

* 20201105 Jesse Meng sync with EMC_POST/develop

* 20201106 Jesse Meng add module UPP_MATH

* 20201113 Jesse Meng add UPP_MATH and UPP_PHYSICS modules and updated with #219

* 20201113 Jesse Meng updated CMakeLists.txt with EMC_post/develop

* 20201113 Jesse Meng fix sorc/ncep_post.fd/CMakeLists.txt for added/removed files

* 20201130 Jesse Meng update modules, move GRIDAVG.f inside module UPP_MATH

* 20201215 Jesse Meng fix EXCH() options in CALVOR and UPP_MATH

* 20201215 Jesse Meng merge with EMC_post/develop

* 20201215 Jesse Meng minor clean up as suggested by reviewers

* 20201218 Jesse Meng revised RH unification
fv3, fv3r, nmmb, use CALRH_NAM
hrrr, rap, use CALRH_GSD

* 20201222 Jesse Meng convert UPP_MATH UPP_PHYSICS docblocks to doxygen format

* 20201223 Jesse Meng minor revision style tweaking

* 20201223 Jesse Meng fix redundance which costs nmmb runtime

Co-authored-by: wx22mj <Jesse.Meng@m71a1.ncep.noaa.gov>
Co-authored-by: wx22mj <Jesse.Meng@m71a3.ncep.noaa.gov>
Co-authored-by: wx22mj <Jesse.Meng@v71a1.ncep.noaa.gov>
Co-authored-by: wx22mj <Jesse.Meng@m71a2.ncep.noaa.gov>
Co-authored-by: wx22mj <Jesse.Meng@m72a1.ncep.noaa.gov>
Co-authored-by: wx22mj <Jesse.Meng@v71a3.ncep.noaa.gov>
Co-authored-by: wx22mj <Jesse.Meng@v72a1.ncep.noaa.gov>
@WenMeng-NOAA WenMeng-NOAA deleted the post_lamx branch April 8, 2021 00:06
WenMeng-NOAA added a commit that referenced this pull request Apr 19, 2021
@fossell @hertneky
@ericaligo-NOAA @DusanJovic-NOAA @ywangwof @climbfuji @WenMeng-NOAA @mkavulich
Merge public v2 (#295)
557ab31 
* Add grib2 output tables for MRW/SRW to InputOutput documentation

* Include a variety of examples for regridding instead of a single generic example

* Minor mod to Acknowledgments

* Replace cld_amt, the 3D cloud fraction from the GFDL mp with the same field for all (#170)

microphysics schemes, cldfra.

* Add (gnu) compiler option to allow argument mismatch. (#179)

gfortran 10.x treats argument mismatch as error

* Change control files names fv3sar->fv3lam to be in-line with SRW release

* Change flat file names fv3sar->fv3lam

* Updated support on Odin & Stampede to use NCEPLIBS public-v2 release

* Change executable name of cmake build for public-v2 to be ncep_post, consistent with other applications

* Update submodule pointer for CMakeModules to fix linker problem against static NetCDF libraries

* Starting UPP version numbers with 10.0.0 for develop branch

* Starting release/public-v2 branch with UPP version 9.0.0

* Remove old community build libraries and gnu make utilities

* Remove configure/compile/clean utilties for old community build

* Modified UPP stand-alone run script with name change to run_upp

* Bug fix for FV3 LAM/LAMX (#219)

* Fix of total cloud fraction in CLDRAD.f for FV3/LAMX.

* Setting  iSF_SURFACE_PHYSICS as 2 in regional FV3 read interface.

* Add/modify RST documentation files for UPP release/public-v2

* Remove Hera GNU from list of supported platforms

* Add link to external wiki page listing NCEPLIBS locations on pre-configured machines

* Adding advanced documentation on how to add a new variable

* modify User Support link and data download link

* Update wgrib2 output, links to grib table descriptions

* Try inter-chapter link

* Another inter-chapter link attempt

* Need autosectionlabel extension for this to work

* Various spelling and format fixes in InputsOutputs

* Minor updates to Installation chapter

* Some more minor changes

* Update CMakeModules

* remove duplicate cldfra variable accidently added in merge

* Documentation updates for GNU version and minor syntax fix.

* Revert module files for Odin and Stampede per ywangwof since build env is handled at app level for these machines

* remove extraneous conflict HEAD line

Co-authored-by: Tracy <hertneky@ucar.edu>
Co-authored-by: ericaligo-NOAA <48365233+ericaligo-NOAA@users.noreply.github.com>
Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Co-authored-by: Yunheng Wang <yunheng.wang@noaa.gov>
Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@guoqing-noaa
CLWMR -> CLMR and use the halo4 mosaic NOAA-EMC#219
0e9a19a 
change CLWMR -> CLMR in the postxconfig-NT file to match the latest GIB2 table
Use the halo4 mosaic file (c3445_mosaic.halo4.nc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericaligo-NOAA ericaligo-NOAA ericaligo-NOAA approved these changes

@HuiyaChuang-NOAA HuiyaChuang-NOAA Awaiting requested review from HuiyaChuang-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenMeng-NOAA @fossell @ericaligo-NOAA