Corrections and fixing double-moment Thompson cloud water

[gthompsnJCSDA]

This update fixes some problems with the code for Thompson microphysics in UPP calculator of effective radius (mostly for CRTM radiance calculations). Most importantly 2-moment cloud water variable (number concentration) should now work as it does in WRF and other models. The graupel Y-intercept parameter is made much simpler in coordination with changes to the latest WRF version of the Thompson microphysics scheme. The code as it was had a serious bug due to the re-usage of the "rg" variable from an included file versus the use in the calculation of effective radius which was using a conflicting name.

[gthompsnJCSDA]

The "Linked issues" portion on the right is not allowing me to LINK a corresponding issue, which is issue#231

[fossell]

@gthompsnJCSDA - Once tested and merge, I assume we will want to pull this into release/public-v2 as well for distribution in the SRW app?
@mkavulich - Please keep an eye on this and bring into public-v2 if needed.

[gthompsnJCSDA]

@gthompsnJCSDA - Once tested and merge, I assume we will want to pull this into release/public-v2 as well for distribution in the SRW app?
@mkavulich - Please keep an eye on this and bring into public-v2 if needed.

Hi Kate - I don't even know what that means about the SRW app - foreign to me. But whatever release, public or not does not concern me, others can decide.

[fossell]

@gthompsnJCSDA - Once tested and merge, I assume we will want to pull this into release/public-v2 as well for distribution in the SRW app?
@mkavulich - Please keep an eye on this and bring into public-v2 if needed.

Hi Kate - I don't even know what that means about the SRW app - foreign to me. But whatever release, public or not does not concern me, others can decide.

@gthompsnJCSDA - Sorry about that, it's the UFS Short Range Weather Application. @mkavulich - Please check with the SRW team to see if this mp option is used or available for the release, if yes we'll need to take this bug fix once it's finalized in develop.

[jwolff-ncar]

Yes, @mkavulich, please make sure this is pulled into public-v2. Thanks!

[WenMeng-NOAA]

The UPP regression tests were conducted on WCOSS Dell, Cray and Hera. With this update, the baseline for hrrr and rap will be re-created.

[WenMeng-NOAA]

This PR is ready for merging.