-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mersenne twister in CALWXT_BOURG.f with standard Fortran RNG #244
Replace mersenne twister in CALWXT_BOURG.f with standard Fortran RNG #244
Conversation
@DusanJovic-NOAA Can you sync your branch with upstream/develop? After that, there might be additional changes in |
@DusanJovic-NOAA
Thanks! |
I can add this. But |
@DusanJovic-NOAA I might think TIMEF.f is an UPP legacy code. Could you add the upgrade in your branch too? Thanks! |
@DusanJovic-NOAA Will you update the file "VERSION" from 10.0.0 to 10.0.1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me, but we do not have any testing on the Fortran random number generator, so the impact of the changes to post products is unknown. As Hui-ya pointed out, a new method may come soon, so this may be some temporary fix.
The UPP regression tests for GFS, GEFS, FV3/LAM, RAP, HRRR were conducted on WCOSS dell, cray and Hera. The precipitation types related fields will have changed results in GFS, GEFS, FV3/LAM products. With this PR merged in develop branch, if there might be scientific concerns from the developing model parallel run, I will provide model developers the guidance of switching back to mersenne twister in their standalone post run. |
…OAA-EMC#243)" (NOAA-EMC#244) This reverts commit c57ce32.
* Changes for running EnKF updates * Adding anavinfo for enkf * Use variables for EnKF cores and walltime * Cosmetic changes to exregional_run_enkf.sh, add some descriptions
In applications like ufs, where different components are built using different precision of default reals, Mersenne twister from w3emc (which does not provide overloaded interfaces) can not be used. Replace it with standard Fortran RNG.