Update fv3lam dataset name convention #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenMeng-NOAA
requested review from
EricRogers-NOAA,
JeffBeck-NOAA and
HuiyaChuang-NOAA
EricRogers-NOAA
approved these changes
Jan 13, 2021
|
The regression tests were conducted on Dell, Cray, Hera. There were no changed results except new baseline created for fv3r. |
JeffBeck-NOAA
approved these changes
Jan 13, 2021
HuiyaChuang-NOAA
approved these changes
Jan 13, 2021
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
…p to the forecast task. (NOAA-EMC#256) Move creation of model_config file from the experiment generation step to the forecast task. Description of changes: ---------------------- In PR#245, the creation of model_config files was moved out of the forecast task (in scripts/exregional_run_fcst.sh) and into the experiment generation step (in ush/generate_FV3SAR_wflow.sh), and a model_config file was created only in the cycle directory (i.e. not in each run directory) assuming that the parameters in model_config will not change for forecasts under a given cycle (e.g. for various ensemble members under a given cycle). Although this is true for certain cases (e.g. cold starts), as pointed out by @christinaholtNOAA, this assumption does not hold in certain use cases (e.g. real-time runs) in which there may be multiple forecasts for a given cycle that need different values of the parameters in model_config (e.g. different forecast lengths, different computational resources, etc). For this reason, a model_config file must be created for each specific forecast and placed in the run directory for that forecast. Thus, in this PR, we move the creation of the model_config files back into the ush/exregional_run_fcst.sh script. Tests conducted: --------------- Ran all WE2E tests on hera. All but 3 passed. The 3 that failed are regional_003, regional_004, and regional_010, but those currently fail in the develop branch with the same errors. File-by-file description of modifications: ----------------------------------------- jobs/JREGIONAL_RUN_FCST: * Set the new cdate argument of the exregional_run_fcst() funciton to CDATE (which is set as an environment variable in the rocoto XML). scripts/exregional_run_fcst.sh: * Add new input argument cdate to this function. This is needed in creating the model_config file for this forecast. * Call the new function create_model_config_file() to create a model_config file in the current run directory. * For ensemble forecasts, remove creation of link to a cycle-specific model_config file. This file is now created on a per-forecast basis. * Edit comments. tests/baselines_list.txt: * Order WE2E test names lexicographically. ush/create_model_config_file.sh: * New function to set the parameters in the model_config file for a given cdate and forecast run directory. ush/create_model_config_files.sh: * Remove this file since the work this used to do for all cycles is now done by the new function ush/create_model_config_file.sh for one cycle. [Actually, this file got renamed to ush/create_model_config_file.sh (drop the "s" after file).] ush/generate_FV3SAR_wflow.sh: * Remove creation of model_config files for all cycles. This is now done on a per-forecast basis in scripts/exregional_run_fcst.sh.
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
…t to write restart files. (NOAA-EMC#256) &fms2_io_nml netcdf_default_format="netcdf4" / 2) Bug fix to GVF update. 3) update location of the retro GVF and snow files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes include: