read and output total aod, dust, SS, SU, OC, and BC aod to grib2 pass regression test at Hera and DELL #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglikate
approved these changes
Feb 22, 2021
|
@zhanglikate You did the changes for outputting aerosol related fields for GEFS V12. Do you think the six new fields Anning has been proposing for MERRA2 aerosol could be unified in block "if (gocart_on)" (starting at line 4433) in subroutine CLDRAD.f? Or making them separated (gocart_on, and RDAOD)? Thanks! |
|
Hi Weng,
It can not use gocart_on, that different AOD generated from FV3GFS online calculation based on MERRA climatological aerosol data, not the online coupling chemical model. It should only use RDAOD. Thanks.
Kate
… On Feb 22, 2021, at 12:39 PM, WenMeng-NOAA ***@***.***> wrote:
@zhanglikate <https://github.com/zhanglikate> You did the changes for outputting aerosol related fields for GEFS V12. Do you think the six new fields Anning has been proposing for MERRA2 aerosol could be unified in block "if (gocart_on)" (starting at line 4433) in subroutine CLDRAD.f? Or making them separated (gocart_on, and RDAOD)? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#263 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APJPDRAFXWYERJMS2PM2V6TTAKXINANCNFSM4XRDJYGQ>.
|
|
@zhanglikate Thanks for clarifying. |
|
@AnningCheng-NOAA Could you sync your branch with latest changes in develop? The procedure can be found at |
WenMeng-NOAA
reviewed
Mar 1, 2021
|
rdaod=.false. in my branch. Do you mean to delete it?
…On Mon, Mar 1, 2021 at 2:43 PM WenMeng-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In scripts/exgfs_atmos_nceppost.sh
<#263 (comment)>:
> @@ -75,7 +75,7 @@ export machine=${machine:-WCOSS_C}
###########################
# Specify Output layers
###########################
-export POSTGPVARS="KPO=57,PO=1000.,975.,950.,925.,900.,875.,850.,825.,800.,775.,750.,725.,700.,675.,650.,625.,600.,575.,550.,525.,500.,475.,450.,425.,400.,375.,350.,325.,300.,275.,250.,225.,200.,175.,150.,125.,100.,70.,50.,40.,30.,20.,15.,10.,7.,5.,3.,2.,1.,0.7,0.4,0.2,0.1,0.07,0.04,0.02,0.01,"
+export POSTGPVARS="KPO=57,PO=1000.,975.,950.,925.,900.,875.,850.,825.,800.,775.,750.,725.,700.,675.,650.,625.,600.,575.,550.,525.,500.,475.,450.,425.,400.,375.,350.,325.,300.,275.,250.,225.,200.,175.,150.,125.,100.,70.,50.,40.,30.,20.,15.,10.,7.,5.,3.,2.,1.,0.7,0.4,0.2,0.1,0.07,0.04,0.02,0.01,rdaod=.false.,"
Please revert the change "rdaod=.false.,"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#263 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIIAJRVBDDBBTPAZ2ILTBPU5NANCNFSM4XRDJYGQ>
.
|
|
@AnningCheng-NOAA Yes, please. |
|
done
…On Mon, Mar 1, 2021 at 3:29 PM WenMeng-NOAA ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> Yes, please.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#263 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMILPYXVE5I4LUH2CIG3TBP2JBANCNFSM4XRDJYGQ>
.
|
WenMeng-NOAA
reviewed
Mar 1, 2021
|
@AnningCheng-NOAA After you commit exgfs_atmos_nceppost.sh, the last step would be sync your branch with upstream/develop via the procedure at |
|
Both have been done. Please let me know if you have any questions
…On Mon, Mar 1, 2021 at 4:18 PM WenMeng-NOAA ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> After you commit
exgfs_atmos_nceppost.sh, the last step would be sync your branch with
upstream/develop via the procedure at
https://github.com/NOAA-EMC/EMC_post/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-original-repository
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#263 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIPYC7HBZF2EMJA66ADTBQADNANCNFSM4XRDJYGQ>
.
|
|
@AnningCheng-NOAA Now your PR is good to me. I will run the final tests. Thanks! |
|
The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. No changed results were found. |
|
@KateFriedman-NOAA Please review the changes for exgdas_atmos_nceppost.sh and exgfs_atmos_nceppost.sh. |
KateFriedman-NOAA
approved these changes
Mar 2, 2021
WenMeng-NOAA
approved these changes
Mar 2, 2021
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
* Update the regional workflow to handle subdomain restart files. * Update configure file for NA 3km to use io_layout_y=10 * Add gsi fix files (subdomain grid spec files) for NA 3km when io_layout(2)=10 Add gsi fix files for CONUS 25km grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read total aod, dust, SS, SU, OC, and BC aods from netcdf file and output to grib2 files. Regression tests have been passed at DELL: /gpfs/dell2/emc/modeling/noscrub/Anning.Cheng/EMC_post, and at Hera: /scratch2/NCEPDEV/climate/Anning.Cheng/EMC_post. New baseline is needed and was produced at post_regression_test_new/data_out.