Remove upp lib dependency on ip, sp and w3nco

[DusanJovic-NOAA]

The upp library does not depend on ip, sp and w3nco libraries. The upp executable does.

[WenMeng-NOAA]

@DusanJovic-NOAA Will this PR make -qopenmp disabled in upp compiling?

[aerorahul]

These changes removes the unnecessary dependencies from the UPP library.
The executable is unchanged.
This PR will allow the UPP library to be built without OpenMP as the transitive dependencies with OpenMP are no longer part of the library.
This needs to be tested.

[aerorahul]

@DusanJovic-NOAA Will this PR make -qopenmp disabled in upp compiling?

Yes if one wishes to build the UPP library without OpenMP.

[DusanJovic-NOAA]

@DusanJovic-NOAA Will this PR make -qopenmp disabled in upp compiling?

Yes. If you pass BUILD_POSTEXEC=OFF and do not turn on OPENMP. I tested only on my laptop using GNU compiler, it needs to be tested on HPCs.

[WenMeng-NOAA]

@DusanJovic-NOAA and @aerorahul Thanks for clarifying. I tested upp lib building on Hera, Venus and saw -qopenmp removed in compiling logs. My test versions are at
/scratch1/NCEPDEV/stmp2/Wen.Meng/dusan/EMC_post/tests/install on Hera
/u/Wen.Meng/noscrubd6/ncep_post/Dusan/EMC_post/tests/install on Venus

[aerorahul]

Thanks to @DusanJovic-NOAA for really drilling into this issue.

[junwang-noaa]

@WenMeng-NOAA, do you want to have the changes included in next upp tag for hpc-stack so that it can be used in inline post?

…

On Fri, Feb 26, 2021 at 11:03 AM Rahul Mahajan ***@***.***> wrote: Thanks to @DusanJovic-NOAA <https://github.com/DusanJovic-NOAA> for really drilling into this issue. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#269 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TL6J4APQKZYBO43CNLTA7A6NANCNFSM4YHHOA4A> .

[WenMeng-NOAA]

@junwang-noaa I have the same thought as you. I will run a quick rt test with the ufs-weather-model and might redo tag upp_v10.0.4.

[WenMeng-NOAA]

The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. No changed results were found. The rt test for regional in-line post in the ufs-weather-model were conducted to test new built upp lib on WCOSS-Dell and Hera. This PR is ready for merging.

[WenMeng-NOAA]

@DusanJovic-NOAA and @aerorahul Thanks for your help!

[WenMeng-NOAA]

@junwang-noaa I recreated the tag upp_v10.0.4 with this new commit for installing upp/10.0.4 at the hpc-stack to support the regional in-line post.

[HuiyaChuang-NOAA]

@WenMeng-NOAA should we have Jesse test this in GFS inline post following Qingfu's procesure?

[HuiyaChuang-NOAA]

@DusanJovic-NOAA @aerorahul thank you for your help.

[WenMeng-NOAA]

@HuiyaChuang-NOAA

should we have Jesse test this in GFS inline post following Qingfu's procesure?
There is no procedure to verify in-line post for FV3GFS yet. It would be great to adapt Qingfu's procedure and set up an standard UPP global in-line post verifying procedure as a part of UPP regression tests in the future. And also consider to expand for regional in-line post.