Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to local copy of FindNetCDF.cmake #385

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

edwardhartnett
Copy link
Collaborator

Fixes #384

switched to local copy of FindNetCDF.cmake

@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. labels Sep 24, 2021
@WenMeng-NOAA
Copy link
Collaborator

The UPP regression tests were successfully completed on WCOSS-Dell, WCOSS-Cray and Hera. No baseline changes.

@fossell
Copy link
Contributor

fossell commented Sep 24, 2021

Proposed changes look ok to me, testing build and quick case now for community standalone apps. Will also need to update documentation accordingly to address removal of submodules and change to clone commands (no need for recurse submodules).
@hertneky - Please take a look at these proposed mods, we'll need to make documentation updates in develop.

@fossell
Copy link
Contributor

fossell commented Sep 24, 2021

Please feel free to merge, I'll create a separate issue for updating documentation to reflect these mods.

@WenMeng-NOAA
Copy link
Collaborator

With this PR merging, I will update the UPP build procedure on WCOSS-Dell, WCOSS-Cray, Hera, Jet and Orion.

@WenMeng-NOAA WenMeng-NOAA merged commit 62dcbd4 into NOAA-EMC:develop Sep 24, 2021
@WenMeng-NOAA
Copy link
Collaborator

@fossell and @hertneky Thanks for documenting UPP updates.

EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
4 participants