Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen for BNDLYR.f #408

Merged
merged 5 commits into from
Oct 28, 2021
Merged

Doxygen for BNDLYR.f #408

merged 5 commits into from
Oct 28, 2021

Conversation

hertneky
Copy link
Contributor

@hertneky hertneky commented Oct 25, 2021

This is part of Issue #392
Fixes the doxygen warnings in BNDLYR.f.

@hertneky
Copy link
Contributor Author

@edwardhartnett One question for you. Is there a standard of how to document a subroutine that has no Inputs or outputs. BNDLYR.f has no inputs, so I did not add anything for that. But, I could add 'param[in] None'. Please advise - thanks!

sorc/ncep_post.fd/BNDLYR.f Outdated Show resolved Hide resolved
sorc/ncep_post.fd/BNDLYR.f Outdated Show resolved Hide resolved
@edwardhartnett
Copy link
Collaborator

@hertneky it's OK if there's no [in] parameters. Just document what is there. If there's no in, there's no in, and that's OK. ;-)

@hertneky hertneky changed the title Doxygen th Doxygen for BNDLYR.f Oct 25, 2021
@hertneky hertneky marked this pull request as ready for review October 25, 2021 21:38
@WenMeng-NOAA WenMeng-NOAA added No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. labels Oct 26, 2021
@WenMeng-NOAA
Copy link
Collaborator

@hertneky Can you sync your branch with upstream/develop? Your PR would be the next one for reviewing, testing and merging. Thanks!

@hertneky
Copy link
Contributor Author

hertneky commented Oct 27, 2021

@WenMeng-NOAA Sync'd and tested on Hera

@WenMeng-NOAA WenMeng-NOAA added the documentation Improvements or additions to documentation label Oct 28, 2021
@WenMeng-NOAA
Copy link
Collaborator

This PR is for documentation enhancement. There are no impact on the UPP regression tests.

@WenMeng-NOAA WenMeng-NOAA merged commit 06c5e22 into NOAA-EMC:develop Oct 28, 2021
@hertneky hertneky deleted the doxygen_th branch May 10, 2022 20:33
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants