Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update modules #493

Closed
wants to merge 2 commits into from

Conversation

jkbk2004
Copy link

@jkbk2004 jkbk2004 commented May 5, 2022

Description:
To update the hpc-stack on Cheyenne for both gnu and Intel: new hpc-stack location and updates on g2/libpng/w3emc

Test:
Tested on Cheyenne for the SRW and stand alone build cases.

@fossell
Copy link
Contributor

fossell commented May 5, 2022

@jkbk2004 or @mkavulich - Do these updated module versions need to be public-v3 release?

@WenMeng-NOAA
Copy link
Collaborator

@jkbk2004 Can you open an issue for this PR? Thanks!

@jkbk2004
Copy link
Author

jkbk2004 commented May 5, 2022

@WenMeng-NOAA I will create an issue.

@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. labels May 5, 2022
@fossell
Copy link
Contributor

fossell commented May 11, 2022

@jkbk2004 - did you create an issue for this yet? I don't see it, can you link it to the draft PR if you've already created it?

@jkbk2004
Copy link
Author

jkbk2004 commented May 11, 2022

@fossell @WenMeng-NOAA I think I have a trouble to use development side bar in this repo. So I am just adding a direct link here of the issue #500 As hpc-stack updates and sync cases are related to other repos, we may need to merge into develop branch, not in release branch.

@WenMeng-NOAA WenMeng-NOAA linked an issue May 11, 2022 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Collaborator

@fossell Do you have more comments on this PR?

@fossell fossell self-requested a review May 11, 2022 16:58
@fossell
Copy link
Contributor

fossell commented May 11, 2022

@jkbk2004 - I see this is still a Draft. Will you have more mods as you work through this issue with other repos? Or is this ready to go as is?

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label May 11, 2022
@jkbk2004
Copy link
Author

@jkbk2004 - I see this is still a Draft. Will you have more mods as you work through this issue with other repos? Or is this ready to go as is?

@fossell I prefer to have some more days since Cheyenne is down. And we can wait to see a progress of srw PR 250

@fossell fossell removed the Ready for Review This PR is ready for code review. label May 11, 2022
@fossell fossell self-requested a review May 11, 2022 17:21
@fossell
Copy link
Contributor

fossell commented May 11, 2022

@jkbk2004 - I see this is still a Draft. Will you have more mods as you work through this issue with other repos? Or is this ready to go as is?

@fossell I prefer to have some more days since Cheyenne is down. And we can wait to see a progress of srw PR 250

@jkbk2004 - Sounds good. Let us know when you're ready and we'll make it ready for review at that point and I can review the final changes. Thanks!

@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS1-Dell. No changed results.

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label May 12, 2022
@WenMeng-NOAA
Copy link
Collaborator

@jkbk2004 Would you change this PR from draft request status for merging, or you have more changes added?

@jkbk2004
Copy link
Author

@WenMeng-NOAA ufs-wm side, intel2022.1 upgrade is on-going. I want to give a week more to merge this PR.

@WenMeng-NOAA
Copy link
Collaborator

@jkbk2004 We have an UPP major upgrade for 2d decomposition within 2 weeks and it will be implemented in ufs-weather-model. If your PR need more time after 5/20, I will create a release branch based on the current develop for your PR merging. Please let me know if my proposal is working for you.

@jkbk2004
Copy link
Author

@WenMeng-NOAA so hpc-stack modulefiles of 2d decomp upgrade will likely be synced with ufs-wm, right? then I think we can hold this PR. My intention is to sync with ufs-wm modulefiles. We don't need any interruption. I am also covering ufs-wm code management side. I can smoothly follow on. If it's better option to close this PR now and reopen later after upgrade, I agree with that option as well.

@WenMeng-NOAA
Copy link
Collaborator

@jkbk2004 The upp is configurated as a submodule of FV3 component in ufs-weather-model instead of pre-installed lib at the hpc-stack module for in-line post. There might be a risk your module update PR following after a large PR. Let's wait for one more week to see which PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA removed the Ready for Review This PR is ready for code review. label May 13, 2022
@WenMeng-NOAA
Copy link
Collaborator

@jkbk2004 May I ask the status of this PR? Thanks!

@jkbk2004
Copy link
Author

jkbk2004 commented Jul 1, 2022

@WenMeng-NOAA I may close the draft and open new one. I still see it will be better to sync modulefiles across machines. There has been a progress on ufs srw app to address this modulefile sync case. I see lua files are directly used on some machines. Is there a reason not using module commands?

@WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA I may close the draft and open new one. I still see it will be better to sync modulefiles across machines. There has been a progress on ufs srw app to address this modulefile sync case. I see lua files are directly used on some machines. Is there a reason not using module commands?

@jkbk2004 Your plan works for me. Per EIB's suggestion, we changed modulefile on WCOSS2 and some R&D machines in lua format so that library versions may be overridden by setting from upstream applications, e.g. global-workflow.

EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Oct 18, 2023
* Enhancement to the workflow for:
1) configure sub-hour model output and generate the right list for running post jobs.
2) turn on DO_SPPT and DO_SKEB and match the namelist requirements
3) add setups for get ics and lbcs to run rertos on WCOSS2.

* Add note to len_fhr in run_post.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cheyenne hpc-stack module update
3 participants