-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update modules #493
Conversation
@jkbk2004 or @mkavulich - Do these updated module versions need to be public-v3 release? |
@jkbk2004 Can you open an issue for this PR? Thanks! |
@WenMeng-NOAA I will create an issue. |
@jkbk2004 - did you create an issue for this yet? I don't see it, can you link it to the draft PR if you've already created it? |
@fossell @WenMeng-NOAA I think I have a trouble to use development side bar in this repo. So I am just adding a direct link here of the issue #500 As hpc-stack updates and sync cases are related to other repos, we may need to merge into develop branch, not in release branch. |
@fossell Do you have more comments on this PR? |
@jkbk2004 - I see this is still a Draft. Will you have more mods as you work through this issue with other repos? Or is this ready to go as is? |
@jkbk2004 - Sounds good. Let us know when you're ready and we'll make it ready for review at that point and I can review the final changes. Thanks! |
The UPP RT tests were completed on WCOSS1-Dell. No changed results. |
@jkbk2004 Would you change this PR from draft request status for merging, or you have more changes added? |
@WenMeng-NOAA ufs-wm side, intel2022.1 upgrade is on-going. I want to give a week more to merge this PR. |
@jkbk2004 We have an UPP major upgrade for 2d decomposition within 2 weeks and it will be implemented in ufs-weather-model. If your PR need more time after 5/20, I will create a release branch based on the current develop for your PR merging. Please let me know if my proposal is working for you. |
@WenMeng-NOAA so hpc-stack modulefiles of 2d decomp upgrade will likely be synced with ufs-wm, right? then I think we can hold this PR. My intention is to sync with ufs-wm modulefiles. We don't need any interruption. I am also covering ufs-wm code management side. I can smoothly follow on. If it's better option to close this PR now and reopen later after upgrade, I agree with that option as well. |
@jkbk2004 The upp is configurated as a submodule of FV3 component in ufs-weather-model instead of pre-installed lib at the hpc-stack module for in-line post. There might be a risk your module update PR following after a large PR. Let's wait for one more week to see which PR is ready for merging. |
@jkbk2004 May I ask the status of this PR? Thanks! |
@WenMeng-NOAA I may close the draft and open new one. I still see it will be better to sync modulefiles across machines. There has been a progress on ufs srw app to address this modulefile sync case. I see lua files are directly used on some machines. Is there a reason not using module commands? |
@jkbk2004 Your plan works for me. Per EIB's suggestion, we changed modulefile on WCOSS2 and some R&D machines in lua format so that library versions may be overridden by setting from upstream applications, e.g. global-workflow. |
* Enhancement to the workflow for: 1) configure sub-hour model output and generate the right list for running post jobs. 2) turn on DO_SPPT and DO_SKEB and match the namelist requirements 3) add setups for get ics and lbcs to run rertos on WCOSS2. * Add note to len_fhr in run_post.
Description:
To update the hpc-stack on Cheyenne for both gnu and Intel: new hpc-stack location and updates on g2/libpng/w3emc
Test:
Tested on Cheyenne for the SRW and stand alone build cases.