-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates for release #499
Conversation
@WenMeng-NOAA, @HuiyaChuang-NOAA - Tracy put together a nice table to be included in the Users Guide for upcoming releases that documents the unified model variables that go into INITPOST_NETCDF. This PR has a number of changes to the UG content, but I wanted to have you take a quick look that this new section 3.1.1. Model Forecast and the associated table of variables too. Once committed, I think this will be helpful for developers to reference, and hopefully keep up to date with it documented in one place in the repo. |
@hertneky @fossell Great job! That's what I have been looking for UPP user support. Two suggestions might be:
|
@camshe - this PR contains updates and link to view updated documentation for the release. |
@WenMeng-NOAA Thanks for the review of the table. I've updated it based on your recommendations. |
@hertneky @fossell |
|
|
@WenMeng-NOAA @HuiyaChuang-NOAA Thanks for the comments. @fossell Based on Huyia's comment about FV3 only being read in using parallel netcdf, should we remove "netcdf" option from the run_upp script? |
@hertneky - This is my misunderstanding, I apologize for that. Yes, we should additionally update the run_upp script. I'll coordinate with you and @kayeekayee to get these mods taken care of. |
@hertneky - Good catch on the version number of seeing that there is a tag for v10.0.12 already. I had only checked release names, and failed to check the tags, that's my oversight. @WenMeng-NOAA - We'll need to update the version number for release/public-v3 and for use when we create a upp release tag. v10.0.13 would be fine, but since 10.0.12 tag you made in March, there was also the unifying of regional and global fv3 interfaces, which could warrant a bigger version change. Thoughts? |
@fossell I would consider about v10.1.0 for release/public-v3, then hot fixes for v10.1.1, v10.1.2, ...? |
@WenMeng-NOAA - It seems a little counterintuitive to me to have the release branch seemingly more ahead of develop, e.g. 10.1.0 > 10.0.13. But I understand the dilemma of having two branches incrementing 10.0.xx potentially at the same time. I'm not sure I have a good solution, we could bump develop to 10.2.0 to reflect the release branch breaking off of develop (and release branch would be 10.1.0 and increment from there)? But if that causes problems on your end, that's ok. We can go with your original proposal. |
@fossell I agree with your solution. The release/public-v3 bump to 10.1.0, and develop bump to 10.2.0. |
@WenMeng-NOAA - sounds good, we'll proceed with that and I'll submit PRs for the version updates. |
@hertneky - please note we've agreed to have release/public-v3 be version 10.1.0. You can update documentation in appropriate places accordingly. Thanks again for catching this! |
@fossell @WenMeng-NOAA I updated the inFormat throughout and the version to 10.1.0 for release/public-v3 - thanks! |
… to the surface variable list (NOAA-EMC#499)
This PR update the documentation for the community release 10.0.12. Highlight include: