Skip to content

Bug fixes in UPP #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2023
Merged

Bug fixes in UPP #797

merged 1 commit into from
Oct 5, 2023

Conversation

WenMeng-NOAA
Copy link
Collaborator

The main changes are:

  • Fix the mis-matched UPP IDs in writing data blocks
  • Assigning 3D radar reflectivity read from model instead of calculation in UPP for GFS V17

@WenMeng-NOAA
Copy link
Collaborator Author

@EricJames-NOAA Can you review the changes in SURFCE.f?

@WenMeng-NOAA
Copy link
Collaborator Author

@JongilHan66 Can you review the changes in MDLFLD.f for GFS V17 radar reflectivity?

JongilHan66
JongilHan66 approved these changes Oct 4, 2023
View reviewed changes
Copy link

@JongilHan66 JongilHan66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in MDLFLD.f for 3D radar reflectivity from model when GFS use Thmopson MP look good.

@WenMeng-NOAA WenMeng-NOAA added bug Something isn't working GFSV17 labels Oct 4, 2023
This was linked to issues Oct 4, 2023
Update for using 3D radar reflectivity from model output for GFS V17 #796
Closed
Correct mismatched GRIB IDs in SURFCE.f #769
Closed
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Oct 5, 2023
@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline changes with this PR.

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs were completed on WCOSS2 without changed results. No changes from the GFS testing due to 3D radar reflectivity not included in the baseline of gfs model output files.

@FernandoAndrade-NOAA
Copy link
Collaborator

Hera, Orion, and Hercules UPP RTs have completed without changes to results.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit f18c1af into NOAA-EMC:develop Oct 5, 2023
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Oct 5, 2023
Closed
@WenMeng-NOAA WenMeng-NOAA deleted the post_bug branch February 23, 2024 13:11
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@EricJames-NOAA EricJames-NOAA Awaiting requested review from EricJames-NOAA

+1 more reviewer

@JongilHan66 JongilHan66 JongilHan66 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working GFSV17 Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update for using 3D radar reflectivity from model output for GFS V17 Correct mismatched GRIB IDs in SURFCE.f
3 participants
@WenMeng-NOAA @FernandoAndrade-NOAA @JongilHan66