Orion module update and typo fixes #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaMeixner-NOAA
approved these changes
May 18, 2023
There was a problem hiding this comment.
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (16 files differ)
mww3_test_03/./work_PR1_MPI_d2 (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (15 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_ufs1.3/./work_a (3 files differ)
Confirmed what Matt found. @MatthewMasarik-NOAA Thanks for fixing these reported typos and for the orion update!! That's a huge help!!!
MatthewMasarik-NOAA
added a commit
to MatthewMasarik-NOAA/WW3
that referenced
this pull request
Jun 27, 2023
* origin/develop: handle NaN air-sea temperatures from nearest land points (NOAA-EMC#869) Increase valid_max for f in ounp (NOAA-EMC#1014) Bugfix deallocation of invalid memory in ww3_prnc (NOAA-EMC#1016) Update to orion intel module path and two typo corrections. (NOAA-EMC#1011) Bugfix to out of bounds array write in w3profsmd_pdlib.f90 (NOAA-EMC#1013) Simple logic fix for time interpolation of boundary nodes at the end of W3XYPFSNIMP. (NOAA-EMC#1005) in w3iors use NSEA instead of NSEAL in serial write/read of VA (NOAA-EMC#954) Update documentation for UNST namelist (NOAA-EMC#986) In certain coupled configurations, the piece of code testing the coupling frequency to check if 'receive' coupling exchanges need to take place fail, resulting in an infinite loop causing the integration between time zero and the first time step to repeat indefinitely. This check needs to be rewritten, which fixes also issue NOAA-EMC#816 in a simpler way. (NOAA-EMC#999)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Update to
orionintelmodule path and two typo corrections.Description
This PR combines:
module usepath fororion.intelregtests to the current path in the ufs-weather-model modulefiles (https://github.com/ufs-community/ufs-weather-model/blob/2cf22273c7eedd6b6b7a0137143a65d675b507cf/modulefiles/ufs_orion.intel.lua#L11). This fixes the 'hanging' behavior that was recently being observed during regtests onorion(see logs below).Please also include the following information:
Issue(s) addressed
Commit Message
Update to
orionintelmodule path and two typo corrections.Check list
Testing
intelregression test matrix run onorion, andhera.orion.intel,hera.intel.Matrix regression tests were run for three cases:
develop- tests inmatrix01,matrix02,matrix03all hung in regression tests at runtime. This is the 'hanging' behavior that had been observed recently. Thecatof these outfiles are posted here to show they each timed out after 8 hours (for referencematrix04--matrix13finished in < 3 hours), along with runs for 'fix1' and 'fix2', which did not hang.matrix.comp).orionmatrix.compfor 'fix1' vs. 'fix2'.orion.matrixCompSummary.txt
orion.matrixCompFull.txt
orion.matrixDiff.txt
note:
orionat times has flakey behavior. The appearance ofww3_tp2.14/./work_OASACM4in the list above is for a text log file,OUTPUT_TOY.txt, which contains an extra record. This is benign and is seen from time to time. The same regtests done onheraconfirm this. In thematrixCompSummary.txtbelow this record is not present.heramatrix.compfor 'develop' vs. 'fix'.