initialize USSP_WN for mod_def

[JessicaMeixner-NOAA]

Pull Request Summary

Initialize USSP_WN for mod_def

Description

If a compiler assigns random numbers instead of zeros you will notice that mod_defs are different because of USSP_WN. While the uninitialized variables are never used, this insures the array is initialized to zero and clean things up for compilers that assign random numbers.

Please also include the following information:

• Add any suggestions for a reviewer: @MatthewMasarik-NOAA
• Mention any labels that should be added: bug
• Are answer changes expected from this PR? Since these variables are never used if you use a compiler that initializes the values to zero by default you will not notice any answer changes. If your compiler initalizes things to random values, you will see differences in mod_defs, but no other answer changes.

Issue(s) addressed

Closes #1160

Commit Message

initialize USSP_WN for mod_def

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? Matrix of regtests on hera with intel. Note other smaller tests were done on hercules + gnu on a branch which is what exposed this issue. We do not see answer changes on hera+intel
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) To see the impact a particular machine/compiler combo is needed.
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? intel on hera
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  Depends on compiler, but for hera+intel, only non-b4b. If you have a compiler that initializes to random numbers, mod_defs will be different.
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

[MatthewMasarik-NOAA]

Thanks @JessicaMeixner-NOAA, I'll put the tests in!

[MatthewMasarik-NOAA]

Code review
Pass

Testing
Pass

Regtests show only the known non-b4b's for changes (with the exception of
ww3_tp2.14/work_OASACM5, which is explained below).

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)
##

ww3_tp2.14/./work_OASACM5                     (1 files differ)
**********************************************************************
************************ identical cases *****************************
**********************************************************************

Note: The logfiles ww3_tp2.14/work_OASACM5/OUTPUT.txt differ with the following line of text

APPLE partitioning

This occurs from time to time and isn't thought to be an issue.

• hera.matrixCompSummary.txt
• hera.matrixCompFull.txt
• hera.matrixDiff.txt

Approved.

[MatthewMasarik-NOAA]

Thanks for catching this initialization issue @JessicaMeixner-NOAA.