Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subroutine for point input/output in netCDF #1168

Closed
wants to merge 9 commits into from

Conversation

edwardhartnett
Copy link
Contributor

Pull Request Summary

add subroutine for point input/output in netCDF

Description

This PR adds the netCDF code to read/write point output, plus some testing.

Issue(s) addressed

#682

Commit Message

add subroutine for point input/output in netCDF

Check list

Testing

Tested in unit testing.

@edwardhartnett
Copy link
Contributor Author

@MatthewMasarik-NOAA we were talking about a regtest for these changes, was it determined that there should be one?

@MatthewMasarik-NOAA
Copy link
Collaborator

Hi @edwardhartnett, since it's a new feature, we should have a regtest. In this case we can basically piggy-back and existing regtest setup, and make an extra run_test call that will exercise the new option of netcdf output. I can help with that. Possibly we can tag-up offline?

@edwardhartnett
Copy link
Contributor Author

I will move this PR to my branch while we work out namelist and regtest issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants