Fix compiler remarks for ST6 and GMD #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JessicaMeixner-NOAA, I will start the tests. |
MatthewMasarik-NOAA
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Code review
Pass
Testing
Pass
The known non-b4b's are present, plus some additional tests with differences restricted to the grid log files, due to the format descriptor changes. These log file differences are consistent with those in the summary output in the PR header -- all checks out.
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (17 files differ)
mww3_test_03/./work_PR1_MPI_d2 (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (12 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (16 files differ)
mww3_test_05/./work_ST6_PR2_UQ_OMP (5 files differ)
mww3_test_05/./work_ST6_PR2_UNO_MPI (5 files differ)
mww3_test_05/./work_ST6_PR2_UNO_OMP (5 files differ)
mww3_test_05/./work_ST6_PR2_UQ_MPI_OMPH (5 files differ)
mww3_test_05/./work_ST6_PR3_UQ_MPI_OMPH (5 files differ)
mww3_test_05/./work_ST6_PR1_MPI (5 files differ)
mww3_test_05/./work_ST6_PR3_UQ_MPI (5 files differ)
mww3_test_05/./work_ST6_PR3_UNO_OMP (5 files differ)
mww3_test_05/./work_ST6_PR3_UQ_OMP (5 files differ)
mww3_test_05/./work_ST6_PR2_UQ_MPI (5 files differ)
mww3_test_05/./work_ST6_PR3_UNO_MPI_OMPH (5 files differ)
mww3_test_05/./work_ST6_PR2_UNO_MPI_OMPH (5 files differ)
mww3_test_05/./work_ST6_PR1_MPI_OMPH (5 files differ)
mww3_test_05/./work_ST6_PR1_OMP (5 files differ)
mww3_test_05/./work_ST6_PR3_UNO_MPI (5 files differ)
mww3_test_09/./work_MPI_ASCII (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.15/./work_ST6FLX5 (1 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_tp2.6/./work_ST4_ASCII (0 files differ)
ww3_ts1/./work_ST4_GMD (1 files differ)
ww3_ts1/./work_ST6 (1 files differ)
ww3_ts1/./work_NL5 (1 files differ)
ww3_ts2/./work_ST6_PR3_UQ (1 files differ)
ww3_ts2/./work_ST6_PR2_UNO (1 files differ)
ww3_ts2/./work_ST6_PR2_UQ (1 files differ)
ww3_ts2/./work_ST6_PR1 (1 files differ)
ww3_ts2/./work_ST6_PR3_UNO (1 files differ)
ww3_ts3/./work_ST6_PR2_UQ_OMP (1 files differ)
ww3_ts3/./work_ST6_PR2_UNO_MPI (1 files differ)
ww3_ts3/./work_ST6_PR2_UNO_OMP (1 files differ)
ww3_ts3/./work_ST6_PR2_UQ_MPI_OMPH (1 files differ)
ww3_ts3/./work_ST6_PR3_UQ_MPI_OMPH (1 files differ)
ww3_ts3/./work_ST6_PR1_MPI (1 files differ)
ww3_ts3/./work_ST6_PR3_UQ_MPI (1 files differ)
ww3_ts3/./work_ST6_PR3_UNO_OMP (1 files differ)
ww3_ts3/./work_ST6_PR3_UQ_OMP (1 files differ)
ww3_ts3/./work_ST6_PR2_UQ_MPI (1 files differ)
ww3_ts3/./work_ST6_PR3_UNO_MPI_OMPH (1 files differ)
ww3_ts3/./work_ST6_PR2_UNO_MPI_OMPH (1 files differ)
ww3_ts3/./work_ST6_PR1_MPI_OMPH (1 files differ)
ww3_ts3/./work_ST6_PR1_OMP (1 files differ)
ww3_ts3/./work_ST6_PR3_UNO_MPI (1 files differ)
ww3_ufs1.3/./work_a (3 files differ)
**********************************************************************
************************ identical cases *****************************
**********************************************************************
|
Thanks for cleaning up these remaining compiler messages @JessicaMeixner-NOAA |
MatthewMasarik-NOAA
added a commit
to MatthewMasarik-NOAA/WW3
that referenced
this pull request
Apr 4, 2024
…ting/pdlib-restarts * origin/testing/pdlib-restarts: Fix compiler remarks for ST6 and GMD (NOAA-EMC#1206) For NCEP regtests, add option for gnu compiler and new machine Hercules (NOAA-EMC#1145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This fixes a few formatting outputs for ST6 and GMD.
Description
This addresses the remaining compiler remarks which were in ST6 and GMD tests. This is just formatting write outputs so the differences are in the ww3_grid.out files.
We should now be able to grep all build.log files for regression tests and ensure that no new remarks come into the code.
Please also include the following information:
Issue(s) addressed
Fixes #1203
Commit Message
Fix compiler remarks for ST6 and GMD
Check list
Testing
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt