Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for wave coupling in NUOPC #196

Merged
merged 5 commits into from
May 11, 2020

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

  • add exports of PSTOKES for WW3->MOM6 coupling
  • add ice value for surface roughness and FLD2 to switch
  • add FieldFill and FieldGather to the timings of wmesmf
  • Updates to compile wmesmf after PR#189
  • Updating Stokes partitions calculation to make sure there are
    default values

* add exports of PSTOKES for WW3->MOM6 coupling
* add ice value for surface roughness and FLD2 to switch
* add FieldFill and FieldGather to the timings of wmesmf
* Updates to compile wmesmf after PR#189
* Updating Stokes partitions calculation to make sure there are
  default values
@JessicaMeixner-NOAA
Copy link
Collaborator Author

This will close issue #191

Results from regression tests will be added when completed.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

matrixout1.tar.gz
matrixout2.tar.gz

The above are two sets of comparisons, the first set and then after PR#194 went through.
The first set of regression tests have the expected differences:


********************* non-identical cases ****************************


mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (10 files differ)
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (6 files differ)
mww3_test_03/./work_PR1_MPI_d2 (7 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c (1 files differ)
mww3_test_04/./work_PR3_UQ_MPI_NC_b_c (2 files differ)
mww3_test_07/./work_PR3_UQ (3 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)

The second set has a few unexpected outfiles with differences, but I did not see any meaningful differences.

@aliabdolali
Copy link
Contributor

@JessicaMeixner-NOAA
It looks good to me. Thanks for putting them together.

@aliabdolali aliabdolali merged commit c53063c into NOAA-EMC:develop May 11, 2020
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the PR/waveoceancpl branch November 13, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants