Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ww3_gint to interpolate restart files #962

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

This PR updates ww3_gint to optionally interpolate restart files.

Description

This updates ww3_gint to interpolate restart files as an option. This is selected via the input file by ww3_gint.inp in the first line to now have the last option:
Time, time increment and number of outputs, and optional T/F -- option (default is T) to indicate out_grd (T) or restart (F)
A new set of regression tests for this is added:

./bin/run_cmake_test -b slurm -o all -S -T -s MPI_OMPH -w work_c -m grdset_c -f -p srun -n 140  -t 4 ../model ww3_ufs1.2
mkdir -p ww3_ufs1.2/work_l
cp ww3_ufs1.2/work_c/restart.hafsl ww3_ufs1.2/work_l/restart.hafsl
./bin/run_cmake_test -b slurm -o all -S -T -s MPI_OMPH -w work_l -m grdset_l -f -p srun -n 140  -t 4 ../model ww3_ufs1.2

which shows the use case of initializing a regional system from a global system.

  • Suggestion for a reviewer: @MatthewMasarik-NOAA
  • Mention any labels that should be added: new feature
  • Are answer changes expected from this PR? Only for the newly added test.

Issue(s) addressed

Commit Message

Update ww3_gint to interpolate restart files

Check list

Testing

  • How were these changes tested? matrix
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes, new test was added
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Yes, hera intel
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.):
    Only the new test
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@MatthewMasarik-NOAA
Copy link
Collaborator

This is great to see @JessicaMeixner-NOAA!! I'll start the regression tests.

@MatthewMasarik-NOAA
Copy link
Collaborator

Status update: I just spoke with @JessicaMeixner-NOAA, and we are both following up one difference that came up in the regtests results.

@MatthewMasarik-NOAA
Copy link
Collaborator

Status: Hera is unavailable today for maintenance. This PR will finish being process tomorrow once hera is back online for developers.

Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt

Code Revew PASS
Testing PASS

This is a very exciting capability to now for restart files! Thank you @JessicaMeixner-NOAA for your determined work to bring this to fruition!!

@MatthewMasarik-NOAA MatthewMasarik-NOAA merged commit c6e7b40 into NOAA-EMC:develop Apr 4, 2023
@ukmo-ccbunney
Copy link
Collaborator

This is a really useful feature. Thanks @JessicaMeixner-NOAA .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gint to regrid restart files as well as output files
3 participants