Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fv3 needs to export the 1-ice fraction that it used in calculating fluxes for export to the coupled model #230

Closed
DeniseWorthen opened this issue Jan 13, 2021 · 8 comments · Fixed by #266
Assignees
Labels
enhancement New feature or request

Comments

@DeniseWorthen
Copy link
Collaborator

Description

FV3 needs to export the open-water fraction to CMEPS so that CMEPS can properly normalize the fluxes imported from FV3 which are sent to other components (ocean,ice).

Solution

A new export variable can be added in setup_exportdata

@junwang-noaa
Copy link
Collaborator

Denise, do you have a standard field name for this open water fraction field? I will use "open_water_faction" for now. I think the same name needs to be used in nems field dictionary and CMEPS.

@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Jan 21, 2021

Yes, it will need to be the same. My working branch is here. I've called it openwater_frac_in_atm. This will be aliased in CMEPS to the name "Sa_ofrac".

This branch also contains a minor bugfix for when dumpfields=true.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Jan 21, 2021 via email

@DeniseWorthen
Copy link
Collaborator Author

Thats a good point but I haven't seen any differences in the exchanged fields until after a few timesteps. The field that FV3 is sending back is meant to be identical to the field it received. Implementing it this way is much simpler than having CMEPS keep two time-levels.

@SMoorthi-emc
Copy link
Contributor

SMoorthi-emc commented Jan 21, 2021 via email

@DeniseWorthen
Copy link
Collaborator Author

because cmeps needs the open water fraction to re-normalize and it no longer has that value available since it would need to be the previous timestep.

@junwang-noaa
Copy link
Collaborator

@DeniseWorthen Is there any update on committing the code changes?

@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Mar 2, 2021

I was going to update the ufs-weather issue #366 today. Yesterday we got Bob Oehmke from ESMF involved in the ancillary issue which arose as part of adding this feature to try to determine if that ancillary issue is an ESMF or CMEPS bug.

I've tested the export field I've created for the open water fraction and it is nearly identical to the imported open water fraction from at the previous timestep. This is the expected behaviour.

As long as this field is not connected, I believe the change could be added to FV3 at any time with no impact on baselines. The FV3 branch I am using for adding this feature is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants